Update to .NET 10, adapt code style to Steeltoe conventions#22
Open
bart-vmware wants to merge 23 commits into
Open
Update to .NET 10, adapt code style to Steeltoe conventions#22bart-vmware wants to merge 23 commits into
bart-vmware wants to merge 23 commits into
Conversation
Preview link: https://netcoretoolservice-pr-22.azurewebsites.net/api/new
|
TimHess
requested changes
Jun 17, 2026
TimHess
reviewed
Jun 22, 2026
| with: | ||
| fetch-depth: 0 # avoid shallow clone so nbgv can do its work. | ||
| - name: Git checkout | ||
| uses: actions/checkout@v6 |
Member
There was a problem hiding this comment.
Suggested change
| uses: actions/checkout@v6 | |
| uses: actions/checkout@v6 | |
| with: | |
| persist-credentials: false |
| await _commandExecutor.ExecuteAsync($"{NetCoreTool.Command} new uninstall {nuGetId}", null, -1); | ||
| if (!AreSensitiveEndpointsEnabled()) | ||
| { | ||
| return StatusCode((int)HttpStatusCode.ServiceUnavailable, SensitiveEndpointUnavailableMessage); |
Member
There was a problem hiding this comment.
503 doesn't seem right for these responses since retrying will still consistently result in failure. Maybe 404 instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the commit messages for details.
Important
This requires a change in Azure: add an environment variable
WEBSITES_PORTwith value8080.