Generate device matrix and add missing symbol#556
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds a Python script that scans Related issues: None provided. Related PRs: None provided. Suggested labels: ci, build-system, tooling Suggested reviewers: None provided. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
Buildscripts/gh-generate-device-matrix.py (1)
17-28: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDuplicate of
device.py'sread_properties_file.This function is an exact copy of the implementation in
device.py(per the provided context snippet). Consider extracting it into a small shared module imported by bothdevice.pyand this script to avoid drift between the two parsers.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2775b923-421c-40e3-ab87-eab4659da160
📒 Files selected for processing (3)
.github/workflows/build.ymlBuildscripts/gh-generate-device-matrix.pyTactilityKernel/source/kernel_symbols.c
Requested in TactilityProject#552 review so CI builds the board. The entry becomes redundant once TactilityProject#556 (generated device matrix) lands — the generator picks the board up from device.properties' hardware.target automatically. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Summary by CodeRabbit