Skip to content

Generate device matrix and add missing symbol#556

Merged
KenVanHoeylandt merged 5 commits into
mainfrom
develop
Jul 8, 2026
Merged

Generate device matrix and add missing symbol#556
KenVanHoeylandt merged 5 commits into
mainfrom
develop

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Firmware builds now automatically generate their device/architecture build matrix by scanning discovered devices instead of relying on a fixed predefined list.
  • Bug Fixes
    • Improved kernel symbol registration so device lookup by type is resolved correctly at runtime.
  • CI / Build Automation
    • Updated the build workflow to compute the matrix dynamically via a generation step, and feed it into the firmware build job for its build strategy.

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8bc453ab-557b-4f2f-ae3a-9caa1940ed93

📥 Commits

Reviewing files that changed from the base of the PR and between 9f110ef and e6e0495.

📒 Files selected for processing (1)
  • .github/workflows/build.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/build.yml

📝 Walkthrough

Walkthrough

This PR adds a Python script that scans Devices/ for device.properties files, reads hardware.target values, and emits a JSON matrix. The build workflow now runs that script in a new GenerateDeviceMatrix job and uses its output for BuildFirmware instead of a fixed matrix. The kernel symbol table also gains device_find_first_by_type.

Related issues: None provided.

Related PRs: None provided.

Suggested labels: ci, build-system, tooling

Suggested reviewers: None provided.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the two main changes: generating the device matrix and adding the missing kernel symbol.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
Buildscripts/gh-generate-device-matrix.py (1)

17-28: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Duplicate of device.py's read_properties_file.

This function is an exact copy of the implementation in device.py (per the provided context snippet). Consider extracting it into a small shared module imported by both device.py and this script to avoid drift between the two parsers.


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2775b923-421c-40e3-ab87-eab4659da160

📥 Commits

Reviewing files that changed from the base of the PR and between f4f91f8 and 021dcf1.

📒 Files selected for processing (3)
  • .github/workflows/build.yml
  • Buildscripts/gh-generate-device-matrix.py
  • TactilityKernel/source/kernel_symbols.c

Comment thread .github/workflows/build.yml
Comment thread .github/workflows/build.yml Outdated
Crazypedia added a commit to Crazypedia/Tactility-lilygo-tdeck-max that referenced this pull request Jul 8, 2026
Requested in TactilityProject#552 review so CI builds the board. The entry becomes
redundant once TactilityProject#556 (generated device matrix) lands — the generator picks
the board up from device.properties' hardware.target automatically.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@KenVanHoeylandt KenVanHoeylandt merged commit dbb96a8 into main Jul 8, 2026
8 of 53 checks passed
@KenVanHoeylandt KenVanHoeylandt deleted the develop branch July 8, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant