remove scripting api's marked as unused#9
Conversation
to ensure removed api's still allow the application to compile, the gradle build and github actions were added for the CI/CD check
krowvin
left a comment
krowvin
left a comment
There was a problem hiding this comment.
Unsure of the args, up to you if that needs a fix!
|
It might not be possible now, but in the future consider multiple PRs for similar efforts. This PR is doing a lot of work and maybe could be split into three separate PRs?
|
rma-psmorris
left a comment
rma-psmorris
left a comment
There was a problem hiding this comment.
Minor request for change and questions.
Yeah that was my original intention, but 1 required 2 (or doing rewrites that would just be thrown away) and knowing how to do 1 required 3 to be done |
rma-psmorris
left a comment
rma-psmorris
left a comment
There was a problem hiding this comment.
Approved, final comment on magic method to save project, we can take that conversation outside of this PR.
3 participants
to ensure removed api's still allow the application to compile, the gradle build and github actions were added for the CI/CD check