Skip to content

Remove legacy tool naming mode#24

Merged
Waishnav merged 5 commits into
mainfrom
refactor/short-tool-names-only
Jun 30, 2026
Merged

Remove legacy tool naming mode#24
Waishnav merged 5 commits into
mainfrom
refactor/short-tool-names-only

Conversation

@Waishnav

@Waishnav Waishnav commented Jun 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove DEVSPACE_TOOL_NAMING and its configuration parsing
  • expose only the short MCP tool names
  • remove legacy tool-name handling from the workspace UI
  • update documentation and environment examples

Existing DEVSPACE_TOOL_NAMING values are ignored after upgrading. MCP clients receive open_workspace, read, write, edit, bash, and the mode-dependent short tools. Pi SDK adapter identifiers remain unchanged because they are internal API names.

Verification

  • npm test
  • npm run typecheck
  • npm run build

Summary by CodeRabbit

  • New Features

    • Tool names are now standardized across the app, with shorter, consistent labels shown in the UI and server instructions.
  • Bug Fixes

    • Removed outdated legacy tool-name references from the interface and configuration examples.
    • Updated styling so shell-related output uses the current tool label consistently.
  • Documentation

    • Refreshed setup and workflow docs to match the new tool naming and configuration behavior.

@Waishnav Waishnav marked this pull request as ready for review June 30, 2026 11:19
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 28e7da58-ba33-4cb0-ad82-c362ab4cfcce

📥 Commits

Reviewing files that changed from the base of the PR and between fa2f7ee and 5430542.

📒 Files selected for processing (9)
  • .env.example
  • docs/chatgpt-coding-workflow.md
  • docs/configuration.md
  • src/config.test.ts
  • src/config.ts
  • src/server.ts
  • src/ui/card-types.ts
  • src/ui/workspace-app.css
  • src/ui/workspace-app.tsx
💤 Files with no reviewable changes (6)
  • src/ui/workspace-app.css
  • src/config.test.ts
  • .env.example
  • src/ui/workspace-app.tsx
  • src/config.ts
  • docs/configuration.md

📝 Walkthrough

Walkthrough

Removes the DEVSPACE_TOOL_NAMING configuration option entirely. The ToolNamingMode type, ServerConfig.toolNaming field, and parseToolNaming helper are deleted from config.ts. In server.ts, conditional tool name resolution is replaced with a fixed toolNames constant, and serverInstructions no longer accepts a toolNames parameter. Legacy tool name literals are removed from ToolName, predicate helpers, getToolDisplay, and CSS selectors. Docs and .env.example are updated to match.

Changes

Remove DEVSPACE_TOOL_NAMING and legacy tool names

Layer / File(s) Summary
Config and UI type system cleanup
src/config.ts, src/ui/card-types.ts, src/config.test.ts
Removes ToolNamingMode, ServerConfig.toolNaming, parseToolNaming, and loadConfig parsing of DEVSPACE_TOOL_NAMING. Drops legacy literals from ToolName union and updates all predicate helpers. Removes associated tests.
Server fixed tool names and instruction wiring
src/server.ts
Replaces toolNamesFor/ToolNames conditional logic with a fixed toolNames constant, simplifies serverInstructions to accept only config, removes toolNames computation in createMcpServer, and hard-codes grep/glob/ls/bash widget titles.
UI display and CSS legacy alias removal
src/ui/workspace-app.tsx, src/ui/workspace-app.css
Removes legacy case labels from getToolDisplay switch and drops .text-payload.run_shell CSS selector.
Docs and env example updates
.env.example, docs/configuration.md, docs/chatgpt-coding-workflow.md
Removes DEVSPACE_TOOL_NAMING from example config, configuration reference table, env-only example command, and coding workflow guide.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 Snip snip went the legacy names,
No more run_shell in these games.
Short names only, clean and bright,
bash and read and ls feel right.
The warren's tidy, the burrow neat—
One less config makes life complete! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: removing the legacy tool naming mode and related configuration.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/short-tool-names-only
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch refactor/short-tool-names-only

Comment @coderabbitai help to get the list of available commands.

…ames-only

# Conflicts:
#	src/config.test.ts
#	src/config.ts
#	src/server.ts
#	src/ui/card-types.ts
#	src/ui/workspace-app.tsx
@Waishnav Waishnav merged commit 6607926 into main Jun 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant