refactor(wb): remove deprecated @typescript/native-preview (tsgo) typecheck fallback#928
Conversation
…echeck fallback TypeScript 7 ships the native compiler as the `typescript` package and wbfy removes `@typescript/native-preview` from all repositories, so the tsgo fallback is dead code. Co-authored-by: WillBooster (Claude Code) <agent@willbooster.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated @typescript/native-preview dependency check from the TypeScript type-checking command builder, as TypeScript 7 now ships the native compiler directly. The reviewer suggested removing the added explanatory comment because it violates the repository style guide, which advises writing comments only for hard-to-understand code.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| // TypeScript 7 ships the native compiler as `typescript` (`tsc`); wbfy removes the | ||
| // deprecated `@typescript/native-preview` (tsgo) preview from all repos, so repos | ||
| // still on the preview should run wbfy instead of relying on a tsgo fallback here. | ||
| if (project.hasOwnDependency('typescript')) { |
There was a problem hiding this comment.
According to the repository style guide, comments should only be written for hard-to-understand code. Since checking for the 'typescript' dependency is straightforward and self-explanatory, this comment is redundant and can be removed.
if (project.hasOwnDependency('typescript')) {References
- Write comments and JSDoc only for hard-to-understand code: explain "why" in comments and "what" in JSDoc. (link)
1 participant
Customer Summary
@typescript/native-previewpreview should run wbfy (which migrates them to TypeScript 7) instead of relying onwb typecheck's tsgo fallback.Technical Summary
@typescript/native-preview→tsgo --noEmitbranch frombuildTypeScriptTypeCheckCommandsinpackages/wb/src/commands/typecheck.ts; type checking now always usestscfrom thetypescriptpackage.Why
typescriptpackage, and wbfy strips@typescript/native-previewfrom every repository it manages (see fix: resolve tsgo from the typescript package instead of @typescript/native-preview build-ts#649 for the related build-ts fix). The tsgo fallback is dead code in the managed fleet.Testing
yarn verify(type checking and linting) — passed with no errors.