Skip to content

Add support for SDK-defined protocol format (JSON or Msgpack) via query parameter#4

Merged
ttypic merged 1 commit into
mainfrom
fix-serialization-handling
Jun 23, 2026
Merged

Add support for SDK-defined protocol format (JSON or Msgpack) via query parameter#4
ttypic merged 1 commit into
mainfrom
fix-serialization-handling

Conversation

@ttypic

@ttypic ttypic commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Update proxy to reflect the actual server logic: the message type is defined by the format parameter, not by the type of the WebSocket frame.

@ttypic ttypic requested a review from paddybyers June 23, 2026 15:12
@ttypic ttypic marked this pull request as ready for review June 23, 2026 15:12

@paddybyers paddybyers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@ttypic ttypic merged commit 6a03e6e into main Jun 23, 2026
2 checks passed
sacOO7 added a commit to ably/specification that referenced this pull request Jun 24, 2026
uts-proxy v0.3.0 (ably/uts-proxy#4) derives a WebSocket message's encoding
from the `format` query parameter — matching the Ably server — rather than
from the WebSocket frame type. The proxy can therefore decode and match both
JSON and msgpack messages, including SDKs (e.g. ably-java) that send JSON
payloads over binary WebSocket frames.
sacOO7 added a commit to ably/specification that referenced this pull request Jun 24, 2026
uts-proxy v0.3.0 (ably/uts-proxy#4) derives a WebSocket message's encoding
from the `format` query parameter — matching the Ably server — rather than
from the WebSocket frame type. The proxy can therefore decode and match both
JSON and msgpack messages, including SDKs (e.g. ably-java) that send JSON
payloads over binary WebSocket frames.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants