Skip to content

[AAASM-4648] 📝 (packaging): Fix misleading OS classifier for platform wheels#261

Merged
Chisanan232 merged 1 commit into
masterfrom
v0.0.1/AAASM-4648/fix_os_classifier
Jul 15, 2026
Merged

[AAASM-4648] 📝 (packaging): Fix misleading OS classifier for platform wheels#261
Chisanan232 merged 1 commit into
masterfrom
v0.0.1/AAASM-4648/fix_os_classifier

Conversation

@Chisanan232

@Chisanan232 Chisanan232 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Description

The published PyPI metadata for agent-assembly declared the trove classifier
Operating System :: OS Independent, but the release ships platform-specific
native (Rust-extension) wheels for macOS and Linux only — there is no Windows
(win_amd64) wheel. A Windows developer trusting the classifier gets no
compatible wheel and the installer falls back to building the sdist, which needs
a Rust/maturin toolchain and fails on a stock Windows machine.

This replaces the false OS Independent claim with the OSes we actually publish
wheels for:

  • Operating System :: POSIX :: Linux
  • Operating System :: MacOS

Windows is out of scope (no win_amd64 wheel is built), so the corrected
classifier now matches the published wheel set. No behavior change — packaging
metadata only.

Type of Change

  • ✨ New feature
  • 🔧 Bug fix
  • ♻️ Refactoring
  • 🍀 Performance improvement
  • 📚 Documentation update
  • 🚀 Release

Breaking Changes

  • No

Related Issues

  • Related JIRA ticket: AAASM-4648
  • Fix Version: agent-assembly v0.0.1-rc.6

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No tests required (explain why)

Metadata-only change. Verified pyproject.toml still parses (tomllib) and the
Operating System classifiers now read POSIX :: Linux + MacOS. Verification
per ticket: the PyPI project page's platform list matches the published wheel set
(Linux/macOS) once rc.6 publishes.

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Comments added for complex logic
  • Documentation updated if needed
  • All tests passing

The published metadata declared 'Operating System :: OS Independent',
but the release ships native (Rust-extension) wheels for macOS and
Linux only — no Windows wheel. Windows installs fell back to a
Rust-requiring sdist build. Replace the false claim with the OSes we
actually publish wheels for.

Refs AAASM-4648
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Chisanan232

Copy link
Copy Markdown
Contributor Author

🤖 Claude Code — PR review

CI state: GREEN — 24/24 checks pass (CI unit+integration, CodeQL, SonarCloud, Codecov, PEP 561, wheel-matrix drift guard, docs build). mergeStateStatus: BLOCKED reflects required-review approval, not a CI failure. Nothing to fix.

Scope coverage: Fully covers AAASM-4648's ## Fix. The ticket offered two options — list the actually-supported OSes, or omit the OS classifier. This PR takes the first: drops the false Operating System :: OS Independent and replaces it with Operating System :: POSIX :: Linux + Operating System :: MacOS, matching the published wheel set (macOS + Linux native wheels; no win_amd64). Windows-out-of-scope is stated per the ticket. No gaps.

Side-effect assessment: None at runtime. The change is packaging metadata only (pyproject.toml trove classifiers); it does not touch any importable module or behavior. pyproject.toml still parses. The corrected classifier is purely advisory PyPI metadata.

FE: No FE-app change; packaging metadata only. Playwright validation N/A.

Verdict: READY to merge (pending required review approval).

@Chisanan232 Chisanan232 merged commit e08cb11 into master Jul 15, 2026
31 checks passed
@Chisanan232 Chisanan232 deleted the v0.0.1/AAASM-4648/fix_os_classifier branch July 15, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant