chore: remove outdated TODO already implemented in VideoPlayerScreen#224
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes a TODO comment regarding handling loading and error states in the VideoPlayerScreen component. No review comments were provided, so there is no feedback to address.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Indeed; the states were added here: https://github.com/android/tv-samples/pull/168/changes#diff-7b344a6e5e297ce690c55b06dab841bb02a31f596dc3dfed24ed054d5351d058R94 Thanks for catching! |
|
@pflammertsma |
What
Remove the obsolete
// TODO: Handle Loading & Error statescomment inVideoPlayerScreen.Why
The
when (uiState)block directly below the comment already handles allVideoPlayerScreenUiStatecases —Loading,Error, andDone.The TODO was left behind after the states were implemented by #168 and is now misleading.
Removing it keeps the code aligned with its actual behavior.
Changes
VideoPlayerScreen.kt.No functional changes.