Skip to content

Refactoring minicluster files to remove 1 TODO#6456

Draft
Amemeda wants to merge 4 commits into
apache:mainfrom
Amemeda:minicluster-files
Draft

Refactoring minicluster files to remove 1 TODO#6456
Amemeda wants to merge 4 commits into
apache:mainfrom
Amemeda:minicluster-files

Conversation

@Amemeda

@Amemeda Amemeda commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Refactoring group of minicluster files into server.base.src.main.java.org.apache.accumulo.server.cluster

@Amemeda

Amemeda commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

This resolves 1 TODO from #2699

@ctubbsii

Copy link
Copy Markdown
Member

The weird thing about these ones is that these classes are supposed to represent a generic cluster, not specifically a minicluster (which is one specific instance of a cluster). So, I'm not sure it makes sense to move them into the minicluster package (which is listed as public API). If possible, it might make sense to move them into the server base jar instead of the minicluster jar, with a package name like org.apache.accumulo.server.cluster, that is not public API.

@Amemeda

Amemeda commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

The weird thing about these ones is that these classes are supposed to represent a generic cluster, not specifically a minicluster (which is one specific instance of a cluster). So, I'm not sure it makes sense to move them into the minicluster package (which is listed as public API). If possible, it might make sense to move them into the server base jar instead of the minicluster jar, with a package name like org.apache.accumulo.server.cluster, that is not public API.

would the rest of the files in minicluster and miniclusterImpl have to move to the new package as well?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants