Refactoring minicluster files to remove 1 TODO#6456
Draft
Amemeda wants to merge 4 commits into
Draft
Conversation
Contributor
Author
|
This resolves 1 TODO from #2699 |
Member
|
The weird thing about these ones is that these classes are supposed to represent a generic cluster, not specifically a minicluster (which is one specific instance of a cluster). So, I'm not sure it makes sense to move them into the minicluster package (which is listed as public API). If possible, it might make sense to move them into the server base jar instead of the minicluster jar, with a package name like org.apache.accumulo.server.cluster, that is not public API. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Refactoring group of minicluster files into
server.base.src.main.java.org.apache.accumulo.server.cluster