Skip to content

Remove protective copies in Thrift APIs#6457

Open
ctubbsii wants to merge 1 commit into
apache:mainfrom
ctubbsii:unsafe-binary-api-thrift
Open

Remove protective copies in Thrift APIs#6457
ctubbsii wants to merge 1 commit into
apache:mainfrom
ctubbsii:unsafe-binary-api-thrift

Conversation

@ctubbsii

Copy link
Copy Markdown
Member

Generate thrift with unsafe_binaries flag to remove unwanted protective copies of ByteBuffer types (we will copy as needed ourselves).

Generate thrift with unsafe_binaries flag to remove unwanted protective
copies of ByteBuffer types (we will copy as needed ourselves).
@ctubbsii ctubbsii added this to the 4.0.0 milestone Jun 30, 2026
@ctubbsii ctubbsii self-assigned this Jun 30, 2026
@ctubbsii

ctubbsii commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

There are a few other options we may want to look at for performance, too. In particular, the option_type=jdk8 (which I intend to do in a subsequent PR), the future_iface (which may be interesting to use), and the reuse_objects (which might require turning back on the protective copies in the APIs) options.

thrift -help 2>&1 | sed -n '/^\s\sjava\s/,/^\s\s\w/p'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant