Skip to content

Deep-copy bootstrap arguments array in BootstrapMethod.copy()#516

Merged
garydgregory merged 1 commit into
apache:masterfrom
rootvector2:bootstrapmethod-copy-arguments
Jul 4, 2026
Merged

Deep-copy bootstrap arguments array in BootstrapMethod.copy()#516
garydgregory merged 1 commit into
apache:masterfrom
rootvector2:bootstrapmethod-copy-arguments

Conversation

@rootvector2

Copy link
Copy Markdown
Contributor

BootstrapMethod.copy() is documented as a deep copy but returns clone(), which leaves the copy sharing the mutable bootstrapArguments int[] with its source; the copy constructor BootstrapMethod(BootstrapMethod) shares it too. Because getBootstrapArguments() returns the raw array, setBootstrapArguments swaps it, and dump() writes it, mutating a copied entry's arguments silently rewrites the original's dumped bytes. Found while checking the per-entry copy() contracts against StackMapEntry.copy(), which reallocates its arrays. Cloning the int[] in both copy paths makes each copy independent.

ModuleExports/ModuleOpens/ModuleProvides also clone() an int[], but keep it final with no raw getter or setter, so their aliasing is not observable and is left unchanged.

  • Read the contribution guidelines for this project.
  • Read the ASF Generative Tooling Guidance if you use Artificial Intelligence (AI).
  • I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
  • Run a successful build using the default Maven goal with mvn; that's mvn on the command line by itself.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.

@garydgregory garydgregory changed the title deep-copy bootstrap arguments array in BootstrapMethod.copy Deep-copy bootstrap arguments array in BootstrapMethod.copy() Jul 4, 2026
@garydgregory garydgregory merged commit 6a89929 into apache:master Jul 4, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants