Match String case folding in TextStringBuilder.equalsIgnoreCase#762
Merged
garydgregory merged 1 commit intoJul 11, 2026
Merged
Conversation
garydgregory
added a commit
that referenced
this pull request
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports apache/commons-lang#1745 to
TextStringBuilder, as requested there.Repro:new TextStringBuilder("K").equalsIgnoreCase(new TextStringBuilder("K"))(KELVIN SIGNU+212AvsK) returnsfalse, and so does the å/ANGSTROM pairnew TextStringBuilder("å").equalsIgnoreCase(new TextStringBuilder("Å")).String.equalsIgnoreCasereturnstruefor both.Cause: the per-character loop only rules a differing pair equal whenCharacter.toUpperCase(c1) == Character.toUpperCase(c2). Characters that fold together only through their lower-case mapping (U+212A->k,U+212B->å) fail that test, so the whole compare reports not-equal.Fix: also accept the pair whenCharacter.toLowerCaseof the upper-cased chars agrees, the same foldString#regionMatchesuses. Regression assertions added toTextStringBuilderTest#testEqualsIgnoreCasefail at the Kelvin pair without the main change and pass with it; all 124 tests in the class pass, and the defaultmvnbuild is green.mvn; that'smvnon the command line by itself.