Update thrift to 0.23.0#17945
Draft
HTHou wants to merge 6 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #17945 +/- ##
============================================
+ Coverage 41.04% 41.09% +0.04%
Complexity 318 318
============================================
Files 5258 5259 +1
Lines 365157 365940 +783
Branches 47204 47329 +125
============================================
+ Hits 149878 150369 +491
- Misses 215279 215571 +292 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
org.apache.thrift:libthriftfrom0.14.1to0.23.0.org.apache.iotdb.tools:iotdb-tools-thriftto0.23.0.0and add the Apache IoTDB staging repositoryorgapacheiotdb-1191so Maven can resolve the staged tool artifacts.libthriftexclusions for the 0.23.0 dependency graph:libthrift:0.23.0(tomcat-embed-core,javax.annotation-api, old HttpClient 4 artifacts);httpclient5,httpcore5,httpcore5-h2);jakarta.servlet-apibecause IoTDB does not use Thrift's servlet transport (TServlet/TExtensibleServlet).jakarta.annotation-apimanaged by IoTDB dependency management; it resolves to3.0.0and is compatible with Thrift 0.23.0.${thrift.version}property and update the binary license dependency list.dorny/paths-filter@v3in client workflows with local Bash path detection so the workflows comply with the repository action allowlist.ServerContextexpectation by returning an explicit shared no-op context from handlers that do not need per-connection state, instead of wrapping all handlers centrally.Validation
mvn spotless:apply -pl iotdb-client/service-rpcmvn dependency:tree -pl iotdb-protocol/thrift-commons -Dincludes=org.apache.httpcomponents.client5,org.apache.httpcomponents.core5 -DskipTestsmvn compile -pl iotdb-protocol/thrift-commons,iotdb-protocol/thrift-datanode,iotdb-client/service-rpc,iotdb-client/jdbc -am -DskipTestsruby -e 'require "yaml"; ARGV.each { |f| YAML.load_file(f); puts "OK #{f}" }' .github/workflows/multi-language-client.yml .github/workflows/client-cpp-package.ymlpom.xml,client-cpp,jdbc, and workflow path changes.org.apache.iotdb.tools:iotdb-tools-thrift:0.23.0.0:mac-aarch64from the staging repository during Thrift code generation.mvn spotless:apply -pl iotdb-core/node-commons,iotdb-core/confignode,iotdb-core/consensus,iotdb-core/datanodemvn test -pl iotdb-core/node-commons -Dtest=NoopServerContextTest,ClientManagerTestmvn dependency:tree -pl iotdb-protocol/thrift-commons -Dincludes=jakarta.annotation:jakarta.annotation-api,jakarta.servlet:jakarta.servlet-api,org.apache.tomcat.embed:tomcat-embed-core,org.apache.httpcomponents.client5,org.apache.httpcomponents.core5 -DskipTestsmvn dependency:tree -pl external-service-impl/rest -Dincludes=jakarta.servlet:jakarta.servlet-api,jakarta.annotation:jakarta.annotation-api -DskipTestsmvn compile -pl iotdb-core/node-commons,iotdb-core/consensus -DskipTestsNotes
A broader local compile including
confignodeanddatanodecurrently hits generated-source cache mismatches unrelated to this change, such as missingTDatabaseInfo#get/setMinSchemaRegionNum,TDatabaseInfo#get/setMinDataRegionNum, and relational grammar generated methods. The focused modules above compile successfully.