refactor(frontend): preserve config source in GuiConfigService instead of one flat map#5673
Draft
Ma77Ball wants to merge 11 commits into
Draft
refactor(frontend): preserve config source in GuiConfigService instead of one flat map#5673Ma77Ball wants to merge 11 commits into
Ma77Ball wants to merge 11 commits into
Conversation
…all/texera into consolidate-batch-size-config-5544
GuiConfigService instead of one flat map
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5673 +/- ##
============================================
- Coverage 53.12% 53.04% -0.09%
- Complexity 2544 2545 +1
============================================
Files 1075 1075
Lines 42232 41743 -489
Branches 4604 4514 -90
============================================
- Hits 22436 22141 -295
+ Misses 18480 18293 -187
+ Partials 1316 1309 -7
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
✅ No material benchmark regressions detected🟢 12 better · 🔴 0 worse · ⚪ 3 noise (<±5%) · 0 without baseline
Baseline detailsLatest main
Raw CSVconfig_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,512.23,200,128000,390,0.238,25233.13,35167.89,35167.89
1,100,10,64,20,2176.11,2000,1280000,919,0.561,105292.72,133991.67,133991.67
2,1000,10,64,20,17885.95,20000,12800000,1118,0.682,894695.81,941525.09,941525.09 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
GuiConfigServiceto store each endpoint's payload under its own key in aconfigBySourcemap (preLogin,gui,amber,userSystem) instead of spreading them all into one flat object, so the origin of every config value is preserved (addresses the review comment on refactor(config): unify default-data-transfer-batch-size into one config key #5545).envgetter fromconfigBySourceon read, keeping its shape identical so the ~50 existingguiConfigService.env.<flag>call sites are untouched.source(name)accessor that returns one endpoint's payload in isolation.Any related issues, documentation, discussions?
Closes: #5669
How was this PR tested?
cd frontend && npx ng test --include="src/app/common/service/gui-config.service.spec.ts"and expect 11 passed (8 existing merge/orchestration tests plus 3 new source-isolation tests).service.env.defaultDataTransferBatchSizestill resolves after post-login load, whileservice.source("amber")returns only the amber payload andservice.source("gui")does not containdefaultDataTransferBatchSize.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF