Schedule HTTP/2 re-enable on NetVConnection owner thread#13362
Open
saimayithri wants to merge 1 commit into
Open
Schedule HTTP/2 re-enable on NetVConnection owner thread#13362saimayithri wants to merge 1 commit into
saimayithri wants to merge 1 commit into
Conversation
Refs: apache#13358 Signed-off-by: saimayithri <saimayithri@gmail.com>
JosiahWI
reviewed
Jul 6, 2026
JosiahWI
left a comment
Contributor
There was a problem hiding this comment.
The code looks good! Thank you for this fix!
Contributor
|
I'm adding this to the v10.2.x project in anticipation that it should be backported. |
Contributor
|
[approve ci] |
Contributor
|
The AuTest subcookie spuriously failed, and the HostDBProcessor regression test failed (unsure if this is spurious). |
Author
|
Thanks for the review, assignment, and for running CI !! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #13358
Summary
Http2CommonSession::state_complete_frame_read()schedulesHTTP2_SESSION_EVENT_REENABLEon the thread currently holding the sessionmutex.
That thread can differ from the underlying
NetVConnectionowner thread.When the re-enable handler later processes frames or releases streams, it can
reach
UnixNetVConnectionqueue operations from the wrong thread and triggerthe NetHandler lock assertion described in #13358.
This change schedules the re-enable event on the session
NetVConnection'sowner thread instead.
Changes
At both HTTP/2 re-enable scheduling sites:
VIOunchanged.get_netvc()->threadas the scheduling target instead ofget_mutex()->thread_holding.NetVConnectionbeforescheduling.
Validation
Built successfully with:
cmake --build build-dev -j4
Ran:
ctest --test-dir build-dev -j4
Scope
This PR addresses the HTTP/2 re-enable path from #13358 only. The separate
HTTP/1.1 cache-write teardown path remains under investigation.