10.1.x: Fix set-status crash inside if/endif at remap time#13366
Open
moonchen wants to merge 1 commit into
Open
10.1.x: Fix set-status crash inside if/endif at remap time#13366moonchen wants to merge 1 commit into
moonchen wants to merge 1 commit into
Conversation
Operators inside an if/endif block never had set_hook() called on them, so _hook retained its default value of TS_HTTP_READ_RESPONSE_HDR_HOOK. When set-status executed at REMAP_PSEUDO_HOOK time, exec() took the response-hook branch and called TSHttpHdrStatusSet on a request buffer, corrupting the header union and crashing. Fix the operator to check TSHttpHdrTypeGet() at runtime instead of trusting get_hook(). Removed _hook and get_hook() from operators. set_hook() becomes is_hook_valid() in Statement and RuleSet to only validate hook compatibility without mutating _hook. Upgrade the HTTPHdr::status_set/reason_set asserts to release_assert so that writing response fields into a request buffer is caught immediately rather than silently corrupting memory. (cherry picked from commit e4728cc)
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #13052.
Operators inside an if/endif block never had set_hook() called on them, so
_hook retained its default value of TS_HTTP_READ_RESPONSE_HDR_HOOK. When
set-status executed at REMAP_PSEUDO_HOOK time, exec() took the
response-hook branch and called TSHttpHdrStatusSet on a request buffer,
corrupting the header union and crashing.
Fix the operator to check TSHttpHdrTypeGet() at runtime instead of trusting
get_hook(). Removed _hook and get_hook() from operators.
set_hook() becomes is_hook_valid() in Statement and RuleSet to only
validate hook compatibility without mutating _hook.
Upgrade the HTTPHdr::status_set/reason_set asserts to release_assert so
that writing response fields into a request buffer is caught immediately
rather than silently corrupting memory.
Did not cherry-pick cleanly: three master-only refactors not in 10.1.x
touch the same lines (enum class HTTPType in #12249, string_view header
accessors in #12243, and the txn/setter overloads for
TSHttpHdrStatusSet/TSHttpTxnStatusSet in #12484). Resolved using 10.1.x's
existing API surface; the logic change is otherwise identical to master.
Not included: the accompanying autest, since the bundle-style replay.yaml
test infrastructure it relies on (#12648) isn't in 10.1.x.
Verified header_rewrite.so and traffic_server build clean on 10.1.x with
this applied.