test: clean up gRPC channels after each test#175
Open
ivanauth wants to merge 1 commit into
Open
Conversation
TestClient built ManagedChannels that were never shut down, so channel cleanup was left to chance. Registering every channel with grpc-testing's GrpcCleanupRule guarantees an orderly shutdown when each test finishes, per https://grpc.io/blog/graceful-cleanup-junit-tests/. Signed-off-by: ivanauth <ivan@authzed.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #113.
Registers each integration-test channel with grpc's
GrpcCleanupRule(io.grpc:grpc-testing) so channels are guaranteed to shut down when the test finishes, per https://grpc.io/blog/graceful-cleanup-junit-tests/. Test-only.