fix: don't call MetadataApplier.fail() after apply() throws#176
Open
ivanauth wants to merge 1 commit into
Open
fix: don't call MetadataApplier.fail() after apply() throws#176ivanauth wants to merge 1 commit into
ivanauth wants to merge 1 commit into
Conversation
BearerToken caught Throwable around the whole metadata application and called applier.fail() on any error. When applier.apply() itself threw, the applier was already finalized, so fail() raised "apply() or fail() already called" and hid the original exception. Only failures while building the metadata now trigger fail(), and the catch is narrowed from Throwable to RuntimeException. Signed-off-by: ivanauth <ivan@authzed.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #117.
If
applier.apply()throws, the applier is already finalized, so the subsequentapplier.fail()raised "apply() or fail() already called" and masked the original exception. This movesapply()outside the try block so its exception propagates as-is, and narrows thecatch (Throwable)tocatch (RuntimeException)(per @tstirrat15's note about not catching all throwables).