feat(core): add Milvus semantic vector backend#1041
Conversation
Signed-off-by: Cheney Zhang <chen.zhang@zilliz.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 389a50f42f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| session, table_name="search_vector_embeddings", dialect_name=dialect_name | ||
| ) | ||
| marker_columns = {"chunk_id", "project_id", "embedding_dims", "updated_at"} | ||
| marker_mismatch = bool(embedding_columns) and not marker_columns.issubset(embedding_columns) |
There was a problem hiding this comment.
Drop existing pgvector table before Milvus markers
When a Postgres project already used the database vector backend, search_vector_embeddings has chunk_id, project_id, embedding_dims, and updated_at plus a NOT NULL embedding vector(...) column, so this subset check treats the pgvector table as a valid Milvus marker table. After users follow the documented backend switch and run bm reindex --embeddings --full, _replace_marker_rows inserts marker rows without embedding, causing the first Milvus sync batch to fail instead of migrating the derived table.
Useful? React with 👍 / 👎.
Signed-off-by: Cheney Zhang <chen.zhang@zilliz.com>
14b7a53 to
f950677
Compare
|
Hi @phernandez @groksrc @jope-bm, could you take a look when you have a chance? This PR adds an optional Milvus semantic vector backend while keeping SQL metadata storage in the existing repository flow. CLA and DCO are passing now. The branch also handles existing pgvector-derived tables separately from Milvus marker tables, with focused coverage in the Milvus repository tests. |
Summary
Testing