Add GitHub Action workflow to run lua tests/test_py.lua#103
Open
cclauss wants to merge 1 commit into
Open
Conversation
4a1c7c2 to
b1baf66
Compare
Contributor
Author
|
@bastibe @gward @leso-kn @shmuz @skorokithakis Your reviews, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a GitHub Action to run
lua tests/test_py.luaso we can focus on fixes for:python.so: undefined symbol:luaL_loadbuffer#98python.so: undefined symbol:lua_insert#99python.so: undefined symbol:luaL_openlibs#100All 10 GHA runs pass on both
ubuntu-26.04andubuntu-26.04-arm.I believe that this is the best GitHub Actions PR to review and merge. It runs a test that passes and can provide feedback for three issues that can then be fixed and closed. Once this is merged, we will have Lua builds with continuous integration basic guardrails in place, and any other GHA PRs can be rebased.