100% Match / Linked Dolphin SDK#736
Open
zcanann wants to merge 3 commits into
Open
Conversation
|
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | .text |
99.99% | 100.00% | +/-0 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | OSInit |
99.96% | 100.00% | +/-0 |
main/dolphin/src/os/OSThread
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | .text |
99.99% | 100.00% | +/-0 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | __OSThreadInit |
99.94% | 100.00% | +/-0 |
main/dolphin/src/os/init/__start
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | .init |
0.00% | 100.00% | +768 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | __check_pad3 |
0.00% | 100.00% | +64 |
| ✅ | __set_debug_bba |
0.00% | 100.00% | +12 |
| ✅ | __get_debug_bba |
0.00% | 100.00% | +8 |
| ✅ | __start |
0.00% | 100.00% | +348 |
| ✅ | __init_registers |
0.00% | 100.00% | +144 |
| ✅ | __init_data |
0.00% | 100.00% | +192 |
main/dolphin/src/os/init/__ppc_eabi_init
| Section | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | .init |
0.00% | 100.00% | +88 |
| Function | From | To | Bytes | |
|---|---|---|---|---|
| ✅ | __init_hardware |
0.00% | 100.00% | +36 |
| ✅ | __flush_cache |
0.00% | 100.00% | +52 |
LivewireCB
reviewed
Jun 21, 2026
|
|
||
| extern u8 __ArenaHi[]; | ||
| extern u8 __ArenaLo[]; | ||
| extern u8 __ArenaHi[] AT_ADDRESS(0x81800000); |
Contributor
There was a problem hiding this comment.
Address should not be hardcoded. It gets pulled from the linker script.
| extern u8 __ArenaHi[]; | ||
| extern u8 __ArenaLo[]; | ||
| extern u8 __ArenaHi[] AT_ADDRESS(0x81800000); | ||
| extern u8 __ArenaLo[] AT_ADDRESS(0x803D9A60); |
Contributor
There was a problem hiding this comment.
Address should not be hardcoded. It gets pulled from the linker script.
| } | ||
|
|
||
| extern u8 _stack_addr[]; | ||
| extern u8 _stack_addr[] AT_ADDRESS(0x803D8A50); |
Contributor
There was a problem hiding this comment.
Address should not be hardcoded. It gets pulled from the linker script.
| "<< Dolphin SDK - OS\trelease build: Apr 17 2003 12:33:06 (0x2301) >>"; | ||
| // needs to be "<< Dolphin SDK - DSP\trelease build: Apr 17 2003 12:34:16 (0x2301) >>"? | ||
| extern char _db_stack_end[]; | ||
| extern char _db_stack_end[] AT_ADDRESS(0x803D8A50); |
Contributor
There was a problem hiding this comment.
Address should not be hardcoded. It gets pulled from the linker script.
Contributor
There was a problem hiding this comment.
Why is this needed?
Using __declspec regularly is perfectly fine for us.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Process for creating this PR, agent assisted: