CI: compat for windows-2025 + vs2026#1975
Merged
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
windows-2025x64 GitHub runner image recently migrated to upgrade to VS 2026. This breaks ROCm, XPU, and CUDA < 13.2 builds in non-trivial ways.This PR mitigates this by setting the MSVC toolset to 14.44 (VS2022) for CUDA and ROCm builds on Windows x64, keeping the
windows-2025runner image. For XPU, I've downgraded towindows-2022to build for the time being.Additionally I've taken the opportunity to clean up a little bit of the build workflow here, namely decoupling the name of the build runner image from the output artifact name. We don't need to cross compile, so GitHub Action's built in
RUNNER_OS(values are Linux/macOS/Windows) andRUNNER_ARCH(values X64 or ARM64), are enough to properly differentiate.For the x64 CPU only build, on Windows we'll now build and ship with VS 2026, as there is no blocker for this.