Timekeeper: Install chronyd as BlueOS tool#3980
Draft
juliusz-t wants to merge 1 commit into
Draft
Conversation
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="core/tools/chrony/chrony.conf" line_range="15-16" />
<code_context>
+# Serve NTP to devices on the vehicle network. Restrict to typical BlueOS subnets.
+# TODO(chrony): drive these from settings / detected interfaces.
+allow 192.168.2.0/24
+allow 192.168.0.0/16
+allow 10.0.0.0/8
+
+# Even with no upstream source, act as a stratum-10 server so vehicle-network
</code_context>
<issue_to_address>
**🚨 issue (security):** Broad NTP "allow" ranges may expose the time service more widely than intended
These broad `allow` ranges expose NTP to most private networks reachable from the container. In deployments where those ranges include non-vehicle devices, this could serve time to unintended clients and increase attack surface. Please narrow the ranges to the specific subnets you expect (or make them configurable) and avoid redundant overlaps like `192.168.2.0/24` plus `192.168.0.0/16`.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Comment on lines
+15
to
+16
| allow 192.168.0.0/16 | ||
| allow 10.0.0.0/8 |
There was a problem hiding this comment.
🚨 issue (security): Broad NTP "allow" ranges may expose the time service more widely than intended
These broad allow ranges expose NTP to most private networks reachable from the container. In deployments where those ranges include non-vehicle devices, this could serve time to unintended clients and increase attack surface. Please narrow the ranges to the specific subnets you expect (or make them configurable) and avoid redundant overlaps like 192.168.2.0/24 plus 192.168.0.0/16.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Add chrony time synchronization tooling to BlueOS and ensure its binaries are included in the core image.
New Features:
Build:
Chores: