uptake instancetypes APi#421
Open
patelspratik wants to merge 4 commits into
Open
Conversation
a8d61ba to
44fc931
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
+ Coverage 20.09% 22.58% +2.49%
==========================================
Files 140 135 -5
Lines 18451 18587 +136
==========================================
+ Hits 3707 4198 +491
+ Misses 14328 13924 -404
- Partials 416 465 +49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move CLI instance catalogs to dev-plane and replace WorkspaceGroups with CloudCreds.
InstanceService.ListOrganizationAvailableInstanceTypes./v1/instance/typesto unauthenticated dev-planeInstanceService.ListPublicInstanceType.cloudCredIddirectly.fileUrltakes precedence over hydratedyamlString, matching the UI. This was exposed by a launchable that succeeded in the UI but failed from the CLI.API Impact
The CLI no longer calls:
GET /api/instances/alltypesavailable/:organizationIdGET /v1/instance/typesOrganization catalogs now use authenticated dev-plane ConnectRPC and include active cloud credentials plus dev-plane provider/cloud filtering. Public
brev searchremains unauthenticated but now callsInstanceService.ListPublicInstanceTypedirectly.The existing
/v1/instance/typesroute remains available for older CLI versions and other consumers.The CLI also no longer:
X-Workspace-Group-IDon brev-deploy or proxy requests.workspaceGroupIdin workspace create requests or launchable labels.POST /api/organizations/:organizationId/workspacesremains in use for creation, but now receivescloudCredIdas the placement identifier.Workspace-Group Removal
WorkspaceGroups.brevSSH user,/home/brev/workspacepath, and automatically generatedbrev proxySSH configuration.workspaceGroupIdresponse fields are ignored.