Add CAP Java 5.0 OpenRewrite recipes to migration table#2647
Conversation
Extend the 'Currently Released CAP Java Migrations' table with the recipes added for the CAP Java 5.0 release (Cap_5.0_Properties, Cap_5.0_OutboxOrdered) and also list the previously missing Cap_4.9_Properties recipe. Add a second table listing the umbrella recipes (Cap_4.8, Cap_4.9, Cap_5.0) and what each one bundles.
Add the recipes introduced after the initial 5.0 recipe list was written, and align names with their YAML definitions: - SearchModeProperty (migrates cds.sql.search.mode → cds.sql.search.localized) - MigrateCdsMavenPluginConfig (migrates cds-maven-plugin config and aligns @sap/cds-dk) - Cap_5.0_OutboxOrdered → CustomOutboxOrdered (renamed in the YAML to drop the version-bound prefix) Also update the Cap_5.0 umbrella description to list the recipes its recipeList now includes.
Reorder both the individual and the umbrella recipe tables so the newest entries by "Available since" come first. Addresses review feedback.
The umbrella table duplicated information from the individual-recipe table above (each row's "Available since" already identifies which umbrella ships it). Drop the table and keep a short note explaining that an umbrella recipe Cap_<major>.<minor> is provided per release. Also remove the now-redundant umbrella sentence from the lead-in paragraph. Addresses review comment #2647 (comment)
|
@renejeglinsky @smahati you can go ahead with this one. :) |
|
I had opencode generate a tool to translate the docu from the recipies' yaml file to markdown: https://github.wdf.sap.corp/cds-java/cds-services/pull/7064/ the idea is that just like we do it for CDSProperties the docu is genarted from the source so that we don't have to review it. |
that's a great idea! I'll have a look at the PR. 👍🏽 |
Co-authored-by: Adrian Görler <adrian.goerler@sap.com>
renejeglinsky
left a comment
There was a problem hiding this comment.
I think that information make sense at the very beginning. WDYT?
Co-authored-by: René Jeglinsky <rene.jeglinsky@sap.com>
Co-authored-by: René Jeglinsky <rene.jeglinsky@sap.com>
Co-authored-by: Adrian Görler <adrian.goerler@sap.com>
Extends the Currently Released CAP Java Migrations table in
java/migration.mdwith the new recipes added for the CAP Java 5.0 release, and adds a second table listing the umbrella recipes.Fine-grained recipes added
Cap_4.9_Properties— was already shipped but missing from the table; renamescds.mcp.autoConfig.*→cds.mcp.autoWired.*andcds.taskScheduler.enabled→cds.outbox.persistent.scheduler.enabled.Cap_5.0_Properties— removes properties no longer supported in CAP Java 5.0 (cds.errors.combined,cds.sql.collate,cds.sql.hana.optimizationMode,cds.odataV4.searchMode,cds.odataV2.searchMode, the two removedcds.multiTenancy.serviceManager.*flags).Cap_5.0_OutboxOrdered— addsordered: trueto customcds.outbox.servicesentries to preserve the previous behavior, since the default flips fromtruetofalsein 5.0.Umbrella recipes table added
New table lists
Cap_4.8,Cap_4.9, andCap_5.0, describing which fine-grained recipes each one bundles and which Maven version it upgrades CAP Java dependencies to.Source: recipe YAMLs under
cds-services-recipes/src/main/resources/META-INF/rewrite/.