Replace @github/webauthn-json references with built-in browser methods#500
Merged
Merged
Conversation
santiagorodriguez96
approved these changes
Jul 2, 2026
santiagorodriguez96
left a comment
santiagorodriguez96
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Thank you so much for your contribution! Just a couple of minor comments 🙂
| # Especially for handling the necessary decoding of the options, and sending the | ||
| # `PublicKeyCredential` object back to the server. | ||
| # For your frontend code, you might find the built-in browser methods useful. | ||
| # Especially the built-in `PublicKeyCredential.parseRequestOptionsFromJSON(options)` for decoding the options, and |
Contributor
There was a problem hiding this comment.
To be honest I'm not convinced with starting the sentence with "Especially..." now – what do you think about:
# The built-in `PublicKeyCredential.parseRequestOptionsFromJSON(options)` allows you to decode the options,
# and the built-in `credential.toJSON()` to send the `PublicKeyCredential` object back to the server.
Contributor
Author
There was a problem hiding this comment.
Fixed ce8a745
English isn't my native language, so I trust your judgment more than mine.
Comment on lines
+195
to
+196
| # Especially the built-in `PublicKeyCredential.parseCreationOptionsFromJSON(options)` for decoding the options, and | ||
| # the built-in `credential.toJSON()` for sending the `PublicKeyCredential` object back to the server. |
| # For your frontend code, you might find @github/webauthn-json npm package useful. | ||
| # Especially for handling the necessary decoding of the options, and sending the | ||
| # `PublicKeyCredential` object back to the server. | ||
| # For your frontend code, you might find the built-in browser methods useful. |
Co-authored-by: Santiago Rodriguez <46354312+santiagorodriguez96@users.noreply.github.com>
Contributor
|
Thank you so much @ttanimichi ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you so much for building and maintaining this amazing gem. It has been incredibly helpful and I truly appreciate all the work that has gone into it.
Summary
ref. https://github.com/github/webauthn-json/blob/7a29471446919d9b45864631f84816c026c9dad8/README.md
@github/webauthn-jsonwas deprecated in March 2025, as all major browsers now natively support the following methods:PublicKeyCredential.parseCreationOptionsFromJSON()PublicKeyCredential.parseRequestOptionsFromJSON()PublicKeyCredential.prototype.toJSON()This PR updates the README to reflect that, replacing references to
@github/webauthn-jsonwith the built-in browser methods.