SP-348: Add command to retrieve single skill files#385
Open
Thomas Neumüller (tneum-celonis) wants to merge 7 commits into
Open
SP-348: Add command to retrieve single skill files#385Thomas Neumüller (tneum-celonis) wants to merge 7 commits into
Thomas Neumüller (tneum-celonis) wants to merge 7 commits into
Conversation
| if (!filePath) { | ||
| return base; | ||
| } | ||
| return `${base}/${encodePathSegments(filePath)}`; |
Contributor
There was a problem hiding this comment.
I think except for the last trailing slash of the full url, path.join can actually do the job itself?
Contributor
Author
There was a problem hiding this comment.
path.join does more than we want here imo because it also collapses ...
|
Zgjim Haziri (ZgjimHaziri)
approved these changes
Jun 25, 2026
Kastriot Salihu (ksalihu)
requested changes
Jun 25, 2026
Kastriot Salihu (ksalihu)
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
asset-registry skills getcommand for downloading skill files registered in the asset registry. By default it fetchesSKILL.mdfor the given--path; pass--file <relative>to retrieve any reference file bundled with the skill, and--output <dir>to choose a destination directory (defaults to cwd).Also refactors a few small bits along the way:
trimSlasheshelper insrc/core/utils/path.ts(used by both the service and the URL-building code).FileService.writeBufferToPathnow reuseswriteBufferToFileWithGivenNamefor the actual write, and a new privateensureDirhelper replaces everyfs.mkdirSync(..., { recursive: true, mode: ... })call in the file.Relevant links
Checklist