Skip to content

Make git unit test not flaky#106

Merged
Andarist merged 6 commits into
mainfrom
unflake-git-unit
Jun 14, 2026
Merged

Make git unit test not flaky#106
Andarist merged 6 commits into
mainfrom
unflake-git-unit

Conversation

@bluwy

@bluwy bluwy commented Jun 12, 2026

Copy link
Copy Markdown
Member

I saw in CI this part

additions: [
{
path: "a.txt",
contents: await fixture.readFile("a.txt", "base64"),
},
{
path: "c.txt",
contents: await fixture.readFile("c.txt", "base64"),
},
{
path: "nested/file.txt",
contents: await fixture.readFile("nested/file.txt", "base64"),
},
],
could fail because the order may be non-deterministic. (c.txt before a.txt)

Added a sort to fix this. Shouldn't affect people in practice but I think it's good to sort in the implementation side so that the requests we send are also deterministic.

Comment thread src/git.ts Outdated
@Andarist Andarist force-pushed the unflake-git-unit branch 2 times, most recently from 0a235d4 to fdaf0f0 Compare June 13, 2026 20:15
@Andarist Andarist mentioned this pull request Jun 13, 2026
@bluwy bluwy requested a review from Andarist June 14, 2026 13:16
@Andarist Andarist added this pull request to the merge queue Jun 14, 2026
Merged via the queue into main with commit dce7e43 Jun 14, 2026
11 checks passed
@Andarist Andarist deleted the unflake-git-unit branch June 14, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants