Generic to_string/formatters with format-spec rendering in hertz (1.2.0)#2
Merged
Conversation
Replace the six per-type to_string overloads and six std::formatter
specializations with one generic template each, covering every
frequency<Rep, Precision> instantiation. An empty format spec keeps the
exact-count form ("433kHz"); any floating-point spec renders the value
in hertz: std::format("{:.1f}", millihertz(1500)) == "1.5Hz".
Output strings are unchanged for all existing typedefs; specs were
previously compile errors, so the spec path is purely additive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors thermo-cpp's formatter generalization (cleishm/thermo-cpp#5): the six per-type
to_stringoverloads and sixstd::formatterspecializations are replaced by one generic template each, covering everyfrequency<Rep, Precision>instantiation (including user-defined ones likefrequency<double, std::mega>). An empty format spec keeps today's exact-count form; any floating-point spec renders the value in hertz:_si_prefixtrait maps precision ratios femto→tera; an unmapped precision with an empty spec throwsformat_errorfromparse()(a compile error for literal format strings), while explicit specs work for any precision.Test plan
-DCONFIG_FREQUENCY_STD_FORMAT=0 -fsyntax-only