#185 - Run quality tools

.php-cs-fixer.dist.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 /*
  * This file is part of the CleverAge/ProcessBundle package.
  *
@@ -33,6 +35,7 @@
         'header_comment' => ['header' => $fileHeaderComment],
         'modernize_strpos' => true,
         'get_class_to_class_keyword' => true,
+        'declare_strict_types' => true,
     ])
     ->setRiskyAllowed(true)
     ->setFinder(

src/CleverAgeProcessBundle.php

@@ -34,6 +34,7 @@ public function build(ContainerBuilder $container): void
         $container->addCompilerPass(new CheckSerializerCompilerPass());
     }
 
+    #[\Override]
     public function getPath(): string
     {
         return \dirname(__DIR__);

src/Configuration/ProcessConfiguration.php

@@ -112,14 +112,7 @@ public function getDependencyGroups(): array
         if (null === $this->dependencyGroups) {
             $this->dependencyGroups = [];
             foreach ($this->getTaskConfigurations() as $taskConfiguration) {
-                $isInBranch = false;
-                foreach ($this->dependencyGroups as $branch) {
-                    if (\in_array($taskConfiguration->getCode(), $branch, true)) {
-                        $isInBranch = true;
-                        break;
-                    }
-                }
-
+                $isInBranch = array_any($this->dependencyGroups, static fn ($branch) => \in_array($taskConfiguration->getCode(), $branch, true));
                 if (!$isInBranch) {
                     $dependencies = $this->buildDependencies($taskConfiguration);
                     $dependencies = $this->sortDependencies($dependencies);

src/Configuration/TaskConfiguration.php

@@ -112,9 +112,7 @@ public function getOutputs(): array
         return $this->outputs;
     }
 
-    /**
-     * @deprecated Use getErrorOutputs method instead
-     */
+    #[\Deprecated(message: 'Use getErrorOutputs method instead')]
     public function getErrors(): array
     {
         @trigger_error('Deprecated method, use getErrorOutputs instead', \E_USER_DEPRECATED);

src/DependencyInjection/Configuration.php

@@ -175,7 +175,7 @@ protected function appendTaskConfigDefinition(NodeBuilder $definition): void
             $definition->arrayNode($nodeName)
                 ->beforeNormalization()
                 ->ifString()
-                ->then(fn ($item): array => [$item])->end()
+                ->then(static fn ($item): array => [$item])->end()
                 ->prototype('scalar');
         }
     }

src/Filesystem/CsvFile.php

@@ -56,11 +56,13 @@ public function __construct(
     /**
      * Will return a resource if the file was created using a resource.
      */
+    #[\Override]
     public function getFilePath(): string
     {
         return $this->filePath;
     }
 
+    #[\Override]
     protected function getResourceName(): string
     {
         return "CSV file '{$this->filePath}'";

src/Logger/TaskProcessor.php

@@ -17,6 +17,7 @@
 
 class TaskProcessor extends AbstractProcessor
 {
+    #[\Override]
     public function __invoke(LogRecord $record): LogRecord
     {
         $record = parent::__invoke($record);

src/Logger/TransformerProcessor.php

@@ -17,6 +17,7 @@
 
 class TransformerProcessor extends AbstractProcessor
 {
+    #[\Override]
     public function __invoke(LogRecord $record): LogRecord
     {
         $record = parent::__invoke($record);

src/Task/File/Csv/AbstractCsvTask.php

@@ -24,6 +24,7 @@
  */
 abstract class AbstractCsvTask extends AbstractCsvResourceTask
 {
+    #[\Override]
     protected function initFile(ProcessState $state): void
     {
         if ($this->csv instanceof CsvResource) {
@@ -41,6 +42,7 @@ protected function initFile(ProcessState $state): void
         );
     }
 
+    #[\Override]
     protected function configureOptions(OptionsResolver $resolver): void
     {
         parent::configureOptions($resolver);

src/Task/File/Csv/CsvReaderTask.php

@@ -82,6 +82,7 @@ protected function getHeaders(ProcessState $state, array $options): ?array
         return $options['headers'];
     }
 
+    #[\Override]
     protected function configureOptions(OptionsResolver $resolver): void
     {
         parent::configureOptions($resolver);

src/Task/File/Csv/CsvSplitterTask.php

@@ -23,6 +23,7 @@
  */
 class CsvSplitterTask extends InputCsvReaderTask
 {
+    #[\Override]
     public function execute(ProcessState $state): void
     {
         $options = $this->getOptions($state);
@@ -49,6 +50,7 @@ public function execute(ProcessState $state): void
      * return true if the task has a next element
      * return false if the task has terminated it's iteration.
      */
+    #[\Override]
     public function next(ProcessState $state): bool
     {
         if (!$this->csv instanceof CsvResource) {
@@ -64,6 +66,7 @@ public function next(ProcessState $state): bool
         return !$endOfFile;
     }
 
+    #[\Override]
     public function finalize(ProcessState $state): void
     {
         if ($this->csv instanceof CsvResource) {
@@ -100,6 +103,7 @@ protected function splitCsv(CsvResource $csv, int $maxLines): string
         return $tmpFilePath;
     }
 
+    #[\Override]
     protected function configureOptions(OptionsResolver $resolver): void
     {
         parent::configureOptions($resolver);

src/Task/File/Csv/CsvWriterTask.php

@@ -43,6 +43,7 @@ public function proceed(ProcessState $state): void
         $state->setOutput($this->csv->getFilePath());
     }
 
+    #[\Override]
     protected function configureOptions(OptionsResolver $resolver): void
     {
         parent::configureOptions($resolver);

src/Task/File/Csv/InputCsvReaderTask.php

@@ -21,6 +21,7 @@
  */
 class InputCsvReaderTask extends CsvReaderTask
 {
+    #[\Override]
     protected function getOptions(ProcessState $state): array
     {
         $options = parent::getOptions($state);
@@ -31,6 +32,7 @@ protected function getOptions(ProcessState $state): array
         return $options;
     }
 
+    #[\Override]
     protected function configureOptions(OptionsResolver $resolver): void
     {
         parent::configureOptions($resolver);

src/Task/File/InputFileReaderTask.php

@@ -21,6 +21,7 @@
  */
 class InputFileReaderTask extends FileReaderTask
 {
+    #[\Override]
     protected function getOptions(ProcessState $state): array
     {
         $options = parent::getOptions($state);
@@ -31,6 +32,7 @@ protected function getOptions(ProcessState $state): array
         return $options;
     }
 
+    #[\Override]
     protected function configureOptions(OptionsResolver $resolver): void
     {
         parent::configureOptions($resolver);

src/Task/File/InputFolderBrowserTask.php

@@ -31,11 +31,13 @@ public function flush(ProcessState $state): void
         $state->setSkipped(true);
     }
 
+    #[\Override]
     public function initialize(ProcessState $state): void
     {
         parent::getOptions($state);
     }
 
+    #[\Override]
     protected function configureOptions(OptionsResolver $resolver): void
     {
         parent::configureOptions($resolver);
@@ -47,6 +49,7 @@ protected function configureOptions(OptionsResolver $resolver): void
         $resolver->setAllowedTypes('base_folder_path', ['string']);
     }
 
+    #[\Override]
     protected function getOptions(ProcessState $state): array
     {
         $options = parent::getOptions($state);

src/Task/File/InputLineReaderTask.php

@@ -21,6 +21,7 @@
  */
 class InputLineReaderTask extends LineReaderTask
 {
+    #[\Override]
     protected function getOptions(ProcessState $state): array
     {
         $options = parent::getOptions($state);
@@ -31,6 +32,7 @@ protected function getOptions(ProcessState $state): array
         return $options;
     }
 
+    #[\Override]
     protected function configureOptions(OptionsResolver $resolver): void
     {
         parent::configureOptions($resolver);

src/Task/FilterTask.php

@@ -28,6 +28,7 @@ class FilterTask extends AbstractConfigurableTask
 {
     use ConditionTrait;
 
+    #[\Override]
     public function initialize(ProcessState $state): void
     {
         parent::initialize($state);

src/Task/IterableBatchTask.php

@@ -35,6 +35,7 @@ public function __construct(
     ) {
     }
 
+    #[\Override]
     public function initialize(ProcessState $state): void
     {
         parent::initialize($state);

src/Task/Process/ProcessExecutorTask.php

@@ -45,6 +45,7 @@ public function execute(ProcessState $state): void
         $state->setOutput($output);
     }
 
+    #[\Override]
     public function initialize(ProcessState $state): void
     {
         parent::initialize($state);

src/Task/Process/ProcessLauncherTask.php

@@ -209,7 +209,7 @@ function (Options $options, $value) {
         $resolver->setAllowedTypes('sleep_interval', ['integer', 'double']);
         $resolver->setAllowedTypes('sleep_interval_after_launch', ['integer', 'double']);
         $resolver->setAllowedTypes('sleep_on_finalize_interval', ['integer', 'double']);
-        $microsecondNormalizer = fn (Options $options, $value): int => (int) ($value * 1_000_000);
+        $microsecondNormalizer = static fn (Options $options, $value): int => (int) ($value * 1_000_000);
         $resolver->setNormalizer('sleep_interval', $microsecondNormalizer);
         $resolver->setNormalizer('sleep_interval_after_launch', $microsecondNormalizer);
         $resolver->setNormalizer('sleep_on_finalize_interval', $microsecondNormalizer);

src/Task/SplitJoinLineTask.php

@@ -21,6 +21,7 @@
  */
 class SplitJoinLineTask extends AbstractIterableOutputTask
 {
+    #[\Override]
     public function next(ProcessState $state): bool
     {
         $valid = parent::next($state);

src/Transformer/CachedTransformer.php

@@ -44,7 +44,7 @@ public function configureOptions(OptionsResolver $resolver): void
         $resolver->setAllowedTypes('ttl', ['null', 'string', \DateTimeInterface::class]);
         $resolver->setNormalizer(
             'ttl',
-            function (Options $options, $value) {
+            static function (Options $options, $value) {
                 /*
                  * Best use is a relative date string like "+1 hour".
                  *

src/Transformer/RulesTransformer.php

@@ -114,7 +114,7 @@ public function configureRuleOptions(OptionsResolver $resolver, ?array $expressi
         };
 
         $resolver->setNormalizer('condition', $expressionNormalizer);
-        $resolver->setNormalizer('default', function (Options $options, $value) {
+        $resolver->setNormalizer('default', static function (Options $options, $value) {
             if ($value && $options['condition']) {
                 throw new \InvalidArgumentException('A rule cannot have a condition and be the default in the same time');
             }