Skip to content

revert: "fix: Externalize react subpaths in dev-pages bundle for Rolldown (#154)"#155

Merged
SpyZzey merged 1 commit into
mainfrom
fix/revert-externalize-react-subpaths
Jun 26, 2026
Merged

revert: "fix: Externalize react subpaths in dev-pages bundle for Rolldown (#154)"#155
SpyZzey merged 1 commit into
mainfrom
fix/revert-externalize-react-subpaths

Conversation

@SpyZzey

@SpyZzey SpyZzey commented Jun 26, 2026

Copy link
Copy Markdown
Member

This reverts commit a7d204f.

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@SpyZzey SpyZzey requested a review from a team as a code owner June 26, 2026 13:12
@SpyZzey SpyZzey requested review from amanabiy and removed request for a team June 26, 2026 13:12
@SpyZzey SpyZzey changed the title Revert "fix: Externalize react subpaths in dev-pages bundle for Rolld… Revert "fix: Externalize react subpaths in dev-pages bundle for Rolldown (#154)" Jun 26, 2026
@SpyZzey SpyZzey changed the title Revert "fix: Externalize react subpaths in dev-pages bundle for Rolldown (#154)" revert: Revert "fix: Externalize react subpaths in dev-pages bundle for Rolldown (#154)" Jun 26, 2026
@SpyZzey SpyZzey changed the title revert: Revert "fix: Externalize react subpaths in dev-pages bundle for Rolldown (#154)" revert: "fix: Externalize react subpaths in dev-pages bundle for Rolldown (#154)" Jun 26, 2026
@SpyZzey SpyZzey enabled auto-merge June 26, 2026 13:14
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (a7d204f) to head (4198f2c).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #155   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines           78        78           
  Branches        21        21           
=========================================
  Hits            78        78           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SpyZzey SpyZzey added this pull request to the merge queue Jun 26, 2026
Merged via the queue into main with commit d19e764 Jun 26, 2026
48 of 51 checks passed
@SpyZzey SpyZzey deleted the fix/revert-externalize-react-subpaths branch June 26, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants