Skip to content

fix(send): sync contacts on in-list grant and fix on-Flipcash scroll offset#1042

Merged
bmc08gt merged 1 commit into
code/cashfrom
fix/contacts-gate-scroll-and-card-sync
Jul 6, 2026
Merged

fix(send): sync contacts on in-list grant and fix on-Flipcash scroll offset#1042
bmc08gt merged 1 commit into
code/cashfrom
fix/contacts-gate-scroll-and-card-sync

Conversation

@bmc08gt

@bmc08gt bmc08gt commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator
  • Keep the contacts permission gate visible until the full sync completes (via ContactSyncComplete) instead of advancing the moment device contacts land. Advancing early rendered the list before on-Flipcash contacts were fetched, then prepended them above the viewport once they arrived — pushing them offscreen so the user had to scroll up.
  • Dispatch ContactsGranted when the user allows access from the in-list rationale card so the contact sync fires, mirroring the gate.
  • Hoist ContactAccessHandle out of ContactList; the screen now owns the single handle and wires both Granted (sync) and Picked (add contacts).

…offset

- Keep the contacts permission gate visible until the full sync completes
  (via ContactSyncComplete) instead of advancing the moment device contacts
  land. Advancing early rendered the list before on-Flipcash contacts were
  fetched, then prepended them above the viewport once they arrived — pushing
  them offscreen so the user had to scroll up.
- Dispatch ContactsGranted when the user allows access from the in-list
  rationale card so the contact sync fires, mirroring the gate.
- Hoist ContactAccessHandle out of ContactList; the screen now owns the single
  handle and wires both Granted (sync) and Picked (add contacts).

Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
@bmc08gt bmc08gt self-assigned this Jul 6, 2026
@bmc08gt bmc08gt merged commit 8270dbd into code/cash Jul 6, 2026
3 checks passed
@bmc08gt bmc08gt deleted the fix/contacts-gate-scroll-and-card-sync branch July 6, 2026 16:03
@github-actions github-actions Bot added the type: fix Bug fix label Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant