fix(send): sync contacts on in-list grant and fix on-Flipcash scroll offset#1042
Merged
Merged
Conversation
bmc08gt
commented
Jul 6, 2026
Collaborator
- Keep the contacts permission gate visible until the full sync completes (via ContactSyncComplete) instead of advancing the moment device contacts land. Advancing early rendered the list before on-Flipcash contacts were fetched, then prepended them above the viewport once they arrived — pushing them offscreen so the user had to scroll up.
- Dispatch ContactsGranted when the user allows access from the in-list rationale card so the contact sync fires, mirroring the gate.
- Hoist ContactAccessHandle out of ContactList; the screen now owns the single handle and wires both Granted (sync) and Picked (add contacts).
…offset - Keep the contacts permission gate visible until the full sync completes (via ContactSyncComplete) instead of advancing the moment device contacts land. Advancing early rendered the list before on-Flipcash contacts were fetched, then prepended them above the viewport once they arrived — pushing them offscreen so the user had to scroll up. - Dispatch ContactsGranted when the user allows access from the in-list rationale card so the contact sync fires, mirroring the gate. - Hoist ContactAccessHandle out of ContactList; the screen now owns the single handle and wires both Granted (sync) and Picked (add contacts). Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.