Skip to content

fix(verification): differentiate between notifiable errors and alerts #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmc08gt merged 1 commit into from
Jul 6, 2026
Merged

fix(verification): differentiate between notifiable errors and alerts #1043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions ...kotlin/com/flipcash/app/contact/verification/internal/phone/PhoneVerificationViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import com.flipcash.services.user.UserManager
import com.flipcash.services.models.PhoneVerificationError
import com.getcode.manager.BottomBarManager
import com.getcode.util.resources.ResourceHelper
import com.getcode.utils.NotifiableError
import com.getcode.utils.TraceType
import com.getcode.utils.trace
import com.getcode.view.BaseViewModel
Expand Down Expand Up @@ -204,25 +205,35 @@ internal class PhoneVerificationViewModel @Inject constructor(
dispatchEvent(Event.OnVerifyingCodeChanged())
}
},
onError = {
trace(message = "Code verification failed: $it", type = TraceType.Error)
onError = { cause ->
trace(message = "Code verification failed: $cause", type = TraceType.Error)
dispatchEvent(Event.OnVerifyingCodeChanged())
val (title, message) = when (it) {
is PhoneVerificationError -> when (it) {
val (title, message) = when (cause) {
is PhoneVerificationError -> when (cause) {
is PhoneVerificationError.Denied -> "Something went wrong" to "You have already sent a verification code"
is PhoneVerificationError.InvalidVerificationCode -> "Something went wrong" to resources.getString(R.string.error_description_invalidVerificationCode)
is PhoneVerificationError.NoVerification -> "Something went wrong" to resources.getString(R.string.error_description_codeTimedOut)
is PhoneVerificationError.RateLimited -> "Something went wrong" to "Too many requests"
is PhoneVerificationError.UnsupportedPhoneType -> resources.getString(R.string.error_title_deviceNotSupported) to resources.getString(R.string.error_description_deviceNotSupported)
else -> null to null
is PhoneVerificationError.InvalidPhoneNumber -> resources.getString(R.string.error_title_failedToSendCodeToPhone) to resources.getString(R.string.error_description_failedToSendCodeToPhone)
is PhoneVerificationError.Other -> resources.getString(R.string.error_title_failedToSendCodeToPhone) to resources.getString(R.string.error_description_failedToSendCodeToPhone)
is PhoneVerificationError.Unrecognized -> resources.getString(R.string.error_title_failedToSendCodeToPhone) to resources.getString(R.string.error_description_failedToSendCodeToPhone)
}
else -> null to null
else -> resources.getString(R.string.error_title_failedToSendCodeToPhone) to resources.getString(R.string.error_description_failedToSendCodeToPhone)
}

BottomBarManager.showError(
title = title ?: resources.getString(R.string.error_title_failedToSendCodeToPhone),
message = message ?: resources.getString(R.string.error_description_failedToSendCodeToPhone),
)
val isError = cause is NotifiableError
if (isError) {
BottomBarManager.showError(
title = title,
message = message,
)
} else {
BottomBarManager.showAlert(
title = title,
message = message,
)
}
}
).launchIn(viewModelScope)

Expand Down
Loading