fix: move DigestHelper from helpers to models/concerns#2706
Merged
Conversation
DigestHelper is a pure utility module (one Digest::MD5 wrapper) that is included by both Member (domain) and ApplicationHelper (presentation). A module in app/helpers/ that domain code depends on is a reverse-layer dependency (domain → presentation). Moving to app/models/concerns/ resolves the violation. Rails autoloading resolves the constant by name, so both include sites continue to work.
KimberleyCook
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Move
DigestHelperfromapp/helpers/toapp/models/concerns/.Why
DigestHelperis a pure utility (oneDigest::MD5wrapper) that is included by bothMember(domain layer) andApplicationHelper(presentation layer). A module inapp/helpers/that domain code depends on is a reverse-layer dependency — the domain should not reach up to presentation.Moving to
app/models/concerns/places it in the correct layer. Rails autoloading resolves by constant name, so bothincludesites continue to work unchanged.Testing
spec/models/member_spec.rb— 38 examples, 0 failuresspec/helpers/application_helper_spec.rb— 18 examples, 0 failures