fix: escape venue/sponsor names with apostrophes in CSS selectors#2707
Merged
Conversation
Faker-generated venue and sponsor names can contain apostrophes (e.g. "Simon O'Connell"), which break single-quoted CSS attribute selectors like `img[alt='...']`. This causes a Nokogiri::CSS::SyntaxError. Switch to double-quoted CSS attribute selectors via Ruby %(...) literal syntax, which handles apostrophes without escaping.
KimberleyCook
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix a test flake in
EventCardComponentwhere Faker-generated venue or sponsor names with apostrophes (e.g.Simon O'Connell) break CSS attribute selectors using single quotes:img[alt='Simon O'Connell'].Root cause
The CSS selector
have_css("img[alt='#{name}'"])uses single-quote delimiters for the attribute value. An apostrophe in the name closes the string early, producing aNokogiri::CSS::SyntaxError.Fix
Switch to double-quoted CSS attribute selectors using Ruby
%(...)literal syntax:have_css(%(img[alt="#{name}"])). Double quotes handle apostrophes in values without escaping.Applies to both occurrences of this pattern in the spec (meeting venue image, sponsor logo image).
CI context
Flake observed in PR #2705 (Group 3, seed 3843):
EventCardComponent with a meeting renders venue image for meetingsTesting
spec/components/event_card_component_spec.rb— 10 examples, 0 failures