fix(coderd_ai_provider): fail clearly when server drops Bedrock role_arn#389
Merged
Merged
Conversation
A Coder server older than v2.35.0 accepts the AI provider request but silently drops the unknown `role_arn` JSON key (`omitempty`), so a configured value round-trips to null in state. Because the bedrock block has sensitive/write-only leaves, Terraform surfaces this as the cryptic "inconsistent values for sensitive attribute" error. Detect this in Create and Update after the API round-trip: if a non-empty requested role_arn comes back empty, return an actionable diagnostic pointing at the version requirement instead. Closes #387
johnstcn
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
role_arnschema docs already note it requires Coder v2.35.0+, but nothing enforced it: on an older server the field is silently dropped (omitempty), round-trips to null, and apply fails with the cryptic "inconsistent values for sensitive attribute" error.This adds an explicit check in
Create/Update— if a requestedrole_arncomes back empty, we fail with a clear diagnostic telling the user to upgrade or remove it.Closes #387
Closes ENG-3027