fixed asset download oom issue#272
Conversation
…o fix/DX-9447-asset-download-oom
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
❌ BUILD FAILED - Security checks failed Please review and fix the security vulnerabilities before merging. |
1 similar comment
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
❌ BUILD FAILED - Security checks failed Please review and fix the security vulnerabilities before merging. |
Summary
finished writing to disk. This made the downloadLimit (default 5) concurrency gate ineffective — new batches kicked off as
fast as HTTP responses arrived, while writes queued up unbounded, exhausting the heap on large asset libraries (FATAL
ERROR: ... JavaScript heap out of memory).
promise only settles once the file write actually completes. This makes downloadLimit throttle real in-flight transfers as
intended.
Testing
stream and asserts the download promise doesn't settle until the write stream ends — fails on pre-fix code, passes with
the fix.