Skip to content

Bugfix/delta#1105

Merged
umesh-more-cstk merged 2 commits into
devfrom
bugfix/delta
Jul 2, 2026
Merged

Bugfix/delta#1105
umesh-more-cstk merged 2 commits into
devfrom
bugfix/delta

Conversation

@yashin4112

Copy link
Copy Markdown
Contributor

🔗 Jira Ticket


📋 PR Type

  • ✨ Feature
  • 🐛 Bug Fix
  • 🔥 Hotfix
  • ♻️ Refactor
  • 🧹 Chore / Dependency Update
  • 📝 Documentation

📝 Description

What changed?

Sitecore asset extraction → Asset Mapper

  • Added a extractAssets lib to migration-sitecore that reads the Sitecore media library (items/master/sitecore/media library), dedupes by a stable item-id uid, and only surfaces assets whose blob ships in blob/master.
  • Wired it into createSitecoreMapper so assetMapping is sent to putTestData — Sitecore media assets now populate the Asset Mapper (previously always empty for Sitecore).

Entry Mapper — Redux/state fixes

  • Preserve the user's unsaved row selections when searching, paging, or clearing the search (previously they were reset from the server response).
  • Stop entry search from wiping the content type's status icon when the mapped entry is filtered out of view.
  • Auto-select the first content type (and load its entries) when applying/resetting the status filter — no more stuck "No Records Found".

UI / layout fixes

  • Added server-side pagination to the entry mapper table (rows-per-page + page nav).
  • Fixed asset name/path cells overflowing into adjacent columns (wrap long text).
  • Fixed the locale dropdown overlapping the table header, and the pagination bar / Save footer layout and table height.

Why?

Sitecore migrations never showed media assets on the Asset Mapper because no assetMapping was ever built on the upload side. The entry mapper also lost in-progress selections and content-type status on search/filter, and had no pagination for large entry lists — plus several layout glitches after adding it.


🧩 Affected Areas

  • api — Node.js backend
  • ui — React frontend
  • upload-api — Upload API server
  • docker / docker-compose
  • CI / GitHub Actions workflows
  • Environment variables / config
  • Other:

🧪 How to Test

  1. Run a Sitecore migration with a package that contains media-library assets → open Assets tab on the mapper → assets appear with name/path/size/CS UID.
  2. On the Entries tab: select an entry (don't save), search for a different entry, clear the search → your selection is still there.
  3. Search for an entry that isn't mapped → the content type's status icon does not disappear.
  4. Apply a status filter, then reset to All → the first content type auto-selects and its entries load.
  5. Change rows-per-page (10/30/50/100) and page through → pagination bar and Save button stay visible; a full page of rows is reachable.

Expected result: Sitecore assets show on the Asset Mapper; entry selections and CT status survive search/filter; pagination works and the layout isn't clipped.


📸 Screenshots / Recordings

Before After
(no Sitecore assets / broken layout) (assets shown + working pagination)

🔗 Related PRs / Dependencies

  • None

✅ Author Checklist

  • Branch follows naming convention: feature/, bugfix/, or hotfix/ + 5–30 lowercase chars
  • Jira ticket linked above
  • Self-reviewed the diff — no debug logs, commented-out code, or TODOs left in
  • .env / example.env updated if new environment variables were added
  • No sensitive credentials or secrets committed
  • Existing tests pass locally (npm test)
  • New tests written (or not applicable — explain why)
  • README.md / docs updated if behaviour changed
  • Talisman pre-push scan passes (no secrets flagged)

👀 Reviewer Notes

  • The Sitecore asset uid is derived from the Sitecore item id (idCorrector), matching what sitecore.service.ts::createAssets assigns at migration time, so delta tracking lines up across iterations.
  • Entry-mapper table height uses a fixed calc(100vh - 520px) (kept in sync between entryMapper.tsx tableHeight and index.scss) — flag if you'd prefer a flex-based layout instead of the pixel offset.
  • There's a commented-out "Total Entries" footer line in entryMapper.tsx — leaving as-is unless you want it removed.

Migration v2 · Docs · Issues

… mapper fixes

- Add Sitecore extractAssets lib and wire it into createSitecoreMapper so
  media-library assets reach putTestData and show on the AssetMapper
- Fix asset/path cells overflowing into adjacent columns (wrap long text)
- Entry mapper: stop search from wiping content-type status icon and
  in-progress unsaved selections
- Add server-side pagination to entry mapper table
- Fix locale dropdown overlap and pagination/footer layout
…arch/filter; pagination + layout fixes

- Keep unsaved row selections when searching/paging/clearing search
- Stop search from wiping the content-type status icon
- Auto-select first content type when resetting/applying status filter
- Add server-side pagination and fix table height / footer layout
@yashin4112 yashin4112 requested a review from a team as a code owner July 2, 2026 12:45
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 1 0 10 ✅ Passed
🟠 High Severity 2 382 25 ✅ Passed
🟡 Medium Severity 0 0 500 ✅ Passed
🔵 Low Severity 1 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

ℹ️ Vulnerabilities Without Available Fixes (Informational Only)

The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:

  • Critical without fixes: 0
  • High without fixes: 382
  • Medium without fixes: 0
  • Low without fixes: 0

✅ BUILD PASSED - All security checks passed

@umesh-more-cstk umesh-more-cstk merged commit 6566c88 into dev Jul 2, 2026
9 checks passed
@umesh-more-cstk umesh-more-cstk deleted the bugfix/delta branch July 2, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants