Waterbody bug fix#1077
Conversation
| gee_account_id=None, | ||
| proj_id=None, | ||
| start_date="2017-07-01", | ||
| end_date="2025-06-30", |
There was a problem hiding this comment.
We should avoid such hard-coding as they are relevant for one year only and we will have to make changes next year again. We should rather restrict the flow if correct parameters are not provided.
| start_date="2017-07-01", | ||
| end_date="2025-06-30", | ||
| start_year=2017, | ||
| end_year=2024, |
There was a problem hiding this comment.
We should avoid such hard-coding as they are relevant for one year only and we will have to make changes next year again. We should rather restrict the flow if correct parameters are not provided.
| start_date="2017-07-01", | ||
| end_date="2025-06-30", | ||
| start_year=2017, | ||
| end_year=2024, |
There was a problem hiding this comment.
We should avoid such hard-coding as they are relevant for one year only and we will have to make changes next year again. We should rather restrict the flow if correct parameters are not provided.
| asset_suffix=None, | ||
| asset_folder_list=None, | ||
| start_date="2017-07-01", | ||
| end_date="2025-06-30", |
There was a problem hiding this comment.
We should avoid such hard-coding as they are relevant for one year only and we will have to make changes next year again. We should rather restrict the flow if correct parameters are not provided.
2 participants
@amanodt Please review and merge. Changes are already in production due to some urgency