Add cancellation-safe quote request metrics#4609
Draft
AryanGodara wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds cancellation-safe metrics for the
/quoteendpoint: every request is counted at handler entry (so client-cancelled/dropped requests are included), plus a separate counter for downstream requests to the price-estimation layer — giving an incoming-vs-downstream viewChanges
Adds three counters
gp_v2_api_quote_requests_started{price_quality}: incremented at handler entry, before the first.await, so cancelled requests are still counted.gp_v2_api_quote_requests_finished{price_quality,result}resultsuccess|error|cancelled, via a Drop guard defaulting tocancelled. Invariant: started == sum(finished).gp_v2_api_quote_downstream_requests{kind}kindtrade|native, incremented per fan-out inOrderQuoter::compute_quote_datafor the incoming-vs-downstream ratio.