Fix Python 3.12 compatibility: event loop,#362
Open
marcfischer wants to merge 1 commit into
Open
Conversation
JSON encoder, and delete serializer
Three bugs surfaced when running against Python 3.12 with the
redesigned
exception hierarchy (CTERAException is now a plain Exception
subclass,
no longer dict-like):
1. clients.py – execute(): asyncio.get_event_loop() raises
RuntimeError in
Python 3.12 when no event loop is set for the current thread. The
module
already creates a dedicated event_loop at import time; use it
directly
instead of going through asyncio.get_event_loop().
2. serializers.py – Encoder.default(): called o.get('__dict__',
None),
treating the object as a dict. SDK Object instances and Exception
subclasses are not dict-like in the current codebase. Replace
with
getattr(o, '__dict__', None) and an explicit Exception branch
that
returns str(o), so CTERAException subclasses (e.g.
AuthenticationError)
serialize to their message string instead of raising TypeError or
AttributeError.
3. clients.py – Client.delete(): unconditionally called
data_serializer(data)
even when data_serializer is None (the default). Callers such as
XML.delete()
intentionally omit the serializer; guard the call with a None
check.
Author
|
without this pr it is not possible to remove a StorageNode: This fails without this PR: Error: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered via: Using the ctera.ctera Ansible collection (v2.3.9)
against a fresh SDK install on Python 3.12+. The collection is no
longer actively maintained and targets an older SDK version where
CTERAException was dict-like — these bugs are therefore unlikely to
surface through the SDK's own test suite.
Reproduction: Install the Ansible collection, run any portal module
(e.g. ctera_portal_storage_node) on Python 3.12, and observe the
errors in sequence:
'MainThread'
'get'
serializable
operations)
JSON encoder, and delete serializer
Three bugs surfaced when running against Python 3.12 with the
redesigned
exception hierarchy (CTERAException is now a plain Exception
subclass,
no longer dict-like):
clients.py – execute(): asyncio.get_event_loop() raises RuntimeError in Python 3.12 when no event loop is set for the current thread. The module already creates a dedicated event_loop at import time; use it directly instead of going through asyncio.get_event_loop().
serializers.py – Encoder.default(): called o.get('dict', None), treating the object as a dict. SDK Object instances and Exception subclasses are not dict-like in the current codebase. Replace with getattr(o, 'dict', None) and an explicit Exception branch that returns str(o), so CTERAException subclasses (e.g. AuthenticationError) serialize to their message string instead of raising TypeError or AttributeError.
clients.py – Client.delete(): unconditionally called data_serializer(data) even when data_serializer is None (the default). Callers such as XML.delete() intentionally omit the serializer; guard the call with a None check.