Behdad bahadivand chegini patch 1#1978
Closed
behdad-bahadivand-chegini wants to merge 3 commits into
Closed
Conversation
fix(configure): also set musescoreDirectPNGPath when MuseScore is chosen The configuration assistant (SelectMusicXMLReader._performAction) now additionally writes the correct `musescoreDirectPNGPath` when the user selects MuseScore as the MusicXML reader. Previously only `musicxmlPath` was set, leaving any stale or broken value for the headless PNG path untouched. This caused `SubConverterException` when calling `show()` in Jupyter notebooks. A helper method `_getMuseScorePNGPathFromApp` resolves the actual command‑line executable on macOS by looking inside the `.app` bundle (`Contents/MacOS/mscore` with fallback to `MuseScore`). On Windows the discovered `.exe` path is used directly.
Revert unintended docstring changes; keep only the musescoreDirectPNGPath fix.
|
coverage: 93.302%. remained the same — behdad-bahadivand-chegini:behdad-bahadivand-chegini-patch-1 into cuthbertLab:master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert unintended docstring changes; keep only the musescoreDirectPNGPath fix