dbeaver/pro#9522 integrate profile selector to connection form#4440
dbeaver/pro#9522 integrate profile selector to connection form#4440sergeyteleshev wants to merge 10 commits into
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 8 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
…ces arrived from backend for both: connection form network handlers & profile form network handlers
|
|
||
| .dbv-kit-select__item { | ||
| display: block; | ||
| display: flex; |
There was a problem hiding this comment.
have you checked ellipsis after this fix?
| * When true for an item, it acts as a group boundary — items are split into | ||
| * SelectGroup chunks separated by a CSS border. Separator items are not rendered. | ||
| */ | ||
| isSeparator?: PropertyGetter<ItemType, boolean>; |
| const getDefaultState = (): INetworkHandlerConfig => SSH_DEFAULT_HANDLER_CONFIG() as INetworkHandlerConfig; | ||
|
|
||
| export class ConnectionFormSSHPart extends FormPart<INetworkHandlerConfig, IConnectionFormState> { | ||
| networkProfileConfig: INetworkHandlerConfig | null; |
There was a problem hiding this comment.
We should not keep this state on the part level, add networkProfileId to the state of the part and use it, please do not declare separate field and methods to this part, part should operate only on its own state
There was a problem hiding this comment.
removed it completely
| secureProperties: schema.record(schema.string(), schema.any()).optional(), | ||
| userName: schema.string().optional(), | ||
| authType: schema.preprocess(nullToUndefined, schema.nativeEnum(NetworkHandlerAuthType).optional()), | ||
| enabled: schema.preprocess(nullToUndefined, schema.boolean().optional()), |
There was a problem hiding this comment.
why do we need this changes? it might break the whole process of saving the network handlers and how backend treats this config
There was a problem hiding this comment.
some fields from backend comes as null which is unexpected for the SSH form validation
and during saving it shows wrong validation
this is backend relative issue which i fixed with mapping nulls to undefined during validation process. it works fine but we agreed to try to fix it on backend side
3 participants
closes https://github.com/dbeaver/pro/issues/9522