V3.9.1#50
Merged
Merged
Conversation
The per-turn footer summed input + output + reasoning + cache read + cache write, so a short prompt over a large cached context read as if it "spent" ~120K tokens when nearly all of that was a cache re-read (billed at a fraction of full price). Show the newly-consumed figure (non-cached input + output + reasoning) as the primary number, with the full per-category split — including cache read/write and the provider's raw total — in a hover tooltip. - Add TokenBreakdown + addTokenBreakdown/getSubagentTokenBreakdown to session-context-metrics; turnTokens becomes turnTokenBreakdown. - Footer renders `spend` under a dashed-underline tooltip trigger. - New i18n keys (en + zh) for the breakdown rows. - Tests cover the reported 120,667 → spend 1,300 case. ### Issue for this PR Closes # ### Type of change - [ ] Bug fix - [ ] New feature - [ ] Refactor / code improvement - [ ] Documentation ### What does this PR do? Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR. **If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!** ### How did you verify your code works? ### Screenshots / recordings _If this is a UI change, please include a screenshot or recording._ ### Checklist - [ ] I have tested my changes locally - [ ] I have not included unrelated changes in this PR _If you do not follow this template your PR will be automatically rejected._ Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
### Issue for this PR Closes # ### Type of change - [ ] Bug fix - [ ] New feature - [ ] Refactor / code improvement - [ ] Documentation ### What does this PR do? Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR. **If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!** ### How did you verify your code works? ### Screenshots / recordings _If this is a UI change, please include a screenshot or recording._ ### Checklist - [ ] I have tested my changes locally - [ ] I have not included unrelated changes in this PR _If you do not follow this template your PR will be automatically rejected._ --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
### Issue for this PR Closes # ### Type of change - [ ] Bug fix - [ ] New feature - [ ] Refactor / code improvement - [ ] Documentation ### What does this PR do? Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR. **If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!** ### How did you verify your code works? ### Screenshots / recordings _If this is a UI change, please include a screenshot or recording._ ### Checklist - [ ] I have tested my changes locally - [ ] I have not included unrelated changes in this PR _If you do not follow this template your PR will be automatically rejected._ --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Four settings/composer UX fixes, rebased cleanly onto the latest `dev` (supersedes #47, whose first 5 commits already landed via #46). ## Changes 1. **Share URL i18n** — the Sharing settings section was English-only; added zh + zht translations and backfilled all 15 non-English locales so the settings-key parity test passes. 2. **Approval control → composer** — removed the auto-accept row from settings; added an `ApprovalControl` next to the build/plan agent selector (Codex-style two-option picker: "Request approval" default / "Auto-approve"), directory-scoped, backed by the existing permission context. 3. **Servers tab** — merged the duplicate "Add server" + "Connect to server" buttons into one "Add server" menu with two items. 4. **Import** — the run button is now a full-width bar button under the options (Cancel beside it while running). ## Verification - App suite: 540 pass - i18n parity: green - Typecheck: clean (15/15 tasks in pre-push) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: deepagent-ai <jamessmithm539@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR.
If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!
How did you verify your code works?
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.