feat: render DB-driven notices and forward CLI/CI identity#58
Merged
Conversation
The CLI now renders deprecation/warn/info/marketing notices the API returns with the compatibility data, honouring --json. Removes the hardcoded iOS-16 warning (now a seeded notice gated on the selected iOS version). - notices.service: Notice type, match-DSL evaluator, level-aware renderer - ci.ts: detectCiContext() resolves provider + wrapper version (DCD_CI_*) - compatibility.ts: carries notices; forwards x-dcd-cli-version + x-dcd-ci-* headers - version.service: export compareSemver for reuse
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
The dcd swagger fix (getBinaryUploadUrl now returns a valid uploads/ staging path) makes the TUS fallback upload succeed against dev storage, so this test no longer fails — invert it to assert the command succeeds and returns a binary id.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // --ignore-sha-check skips the dedup short-circuit and performs a real | ||
| // upload. The mock returns a valid `uploads/` staging path, so the TUS | ||
| // fallback upload succeeds and the command returns the new binary id. | ||
| const { stdout } = await exec(command, { timeout: 60_000 }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The CLI now renders deprecation/warn/info/marketing notices the API returns with the compatibility data, honouring --json. Removes the hardcoded iOS-16 warning (now a seeded notice gated on the selected iOS version).
Type of change
fix— bug fixfeat— new featureperf— performance improvementrefactor— code change that's neither a fix nor a featuredocs— documentation onlychore/ci/build/test— tooling, no user-facing change!or PR notes aBREAKING CHANGE:)Checklist
pnpm lintpassespnpm typecheckpassespnpm buildpassesCHANGELOG.md(release-please handles this)README.md/STYLE_GUIDE.mdupdated if behaviour or output changedHow to test