Feat: full_label field can be used instead of the label#15950
Open
ivellios wants to merge 1 commit into
Open
Conversation
…e label
Using label implies that in the template of the event each section of the sponsors will show up as \{label\} Sponsors.
Some events may need to add different types of partners, which are not explicitly Sponsors and adding automatic suffix
of Sponsors makes them look awkward.
To avoid that, this commit introduces a new field full_label which - when set - will be used
in place of the 'label' Sponsors.
The default still falls into label to maintain old events.
The same rule applies to 'Join as...' link in the section. The label field is not required if full_label is used.
✅ Deploy Preview for devopsdays-web ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Using the
labelfield implies that in the template of the event, each section of the sponsors will show up as[label] Sponsors(with the Sponsors suffix). Some events may want/need to add different types of partners that are not explicitly Sponsors, and adding an automatic suffix of Sponsors makes them look awkward.Proposal
To avoid that, this commit introduces a new field
full_labelwhich - when set - will be used in place of the[label] Sponsors(replacing it fully).The same rule applies to the Join as... link in the section. The
labelfield is not required iffull_labelis used instead.Backwards compatibility
The default still falls into the
labelfield to maintain old events.Example
Closes #14456