Skip to content

chore: small updates#309

Merged
digitalghost-dev merged 3 commits into
mainfrom
small-edits
Jun 25, 2026
Merged

chore: small updates#309
digitalghost-dev merged 3 commits into
mainfrom
small-edits

Conversation

@digitalghost-dev

@digitalghost-dev digitalghost-dev commented Jun 25, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Documentation

    • Expanded the installation guide with clearer update steps for Homebrew, Scoop, Linux packages, Docker, and Go installs.
    • Updated the table of contents and reorganized the installation section (now “Installation & Updating”).
  • Bug Fixes

    • Improved the local development startup flow by validating/parsing project data before launching the Dagster server.
  • Chores

    • Updated the release workflow to grant write access required for SBOM generation and upload.
    • Removed an outdated demo recording script.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 13afdea3-c0be-4e10-a1aa-e5b99fd601ce

📥 Commits

Reviewing files that changed from the base of the PR and between 2cad8f5 and 662e13f.

📒 Files selected for processing (2)
  • README.md
  • data_platform/infrastructure/start-dagster.sh
✅ Files skipped from review due to trivial changes (1)
  • README.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • data_platform/infrastructure/start-dagster.sh

📝 Walkthrough

Walkthrough

The PR renames and expands the README installation section, adds dbt parse before Dagster startup, and grants the release workflow’s syft job write access to contents.

Changes

Installation docs refresh

Layer / File(s) Summary
Section rename and layout
README.md
The table of contents and installation heading change to “Installation & Updating”.
Update instructions
README.md
Homebrew, Scoop, Linux packages, Docker image, binary, and source install instructions add update steps.

Dagster startup parse step

Layer / File(s) Summary
Parse dbt before dev startup
data_platform/infrastructure/start-dagster.sh
The script adds dbt parse with explicit project and profiles directories before dg dev.

Release workflow permissions

Layer / File(s) Summary
Syft job permissions
.github/workflows/release.yml
The syft job gains a job-level permissions block with contents: write before the artifact download and SBOM upload steps.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

I hop through docs with twitchy cheer,
And dbt parse now starts me here.
The release stars wink, the guide lines glow,
My carrot paws tap to-and-fro.
Hooray for updates, neat and bright! 🐰

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is too vague and generic to convey the main change in this pull request. Use a concise, specific title that reflects the main update, such as permissions, README installation updates, and the Dagster startup change.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch small-edits

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codspeed-hq

codspeed-hq Bot commented Jun 25, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 53 untouched benchmarks
⏩ 63 skipped benchmarks1


Comparing small-edits (662e13f) with main (932d033)

Open in CodSpeed

Footnotes

  1. 63 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@data_platform/infrastructure/start-dagster.sh`:
- Around line 57-60: The startup flow in the Dagster launcher currently ignores
a failing dbt parse and still continues into exec dg dev. Update the start-up
sequence in start-dagster.sh so that dbt parse failures stop the script
immediately, either by enabling strict shell error handling or by explicitly
checking the dbt parse exit status before launching Dagster. Make sure the guard
is placed around the dbt parse step and the exec dg dev handoff so
transform_data.py is never started with a missing or stale manifest.

In `@README.md`:
- Around line 113-121: The README update instructions for RPM installs are too
generic and currently use yum, which does not apply to openSUSE. Update the
install guidance in the “To update” section to distinguish openSUSE from other
RPM-based systems: either add a separate zypper update command for openSUSE or
remove openSUSE from the RPM update wording. Use the update snippet in README
and the package update examples as the location reference.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ecaeb2ec-6c3b-435f-ad6d-b354a8bb8c1a

📥 Commits

Reviewing files that changed from the base of the PR and between 932d033 and 2cad8f5.

⛔ Files ignored due to path filters (1)
  • demo.gif is excluded by !**/*.gif
📒 Files selected for processing (4)
  • .github/workflows/release.yml
  • README.md
  • data_platform/infrastructure/start-dagster.sh
  • demo.tape
💤 Files with no reviewable changes (1)
  • demo.tape

Comment thread data_platform/infrastructure/start-dagster.sh
Comment thread README.md
@digitalghost-dev digitalghost-dev merged commit 507c8a5 into main Jun 25, 2026
13 checks passed
@digitalghost-dev digitalghost-dev deleted the small-edits branch June 25, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant