fix(mssql): remove invalid auth modes; suppress azure-identity log noise (#1754 follow-up)#1756
Merged
Merged
Conversation
ActiveDirectoryAzCli and ActiveDirectoryWorkloadIdentity do not exist in the mssql-jdbc 12.6.1 SqlAuthentication enum — they are .NET/Go driver concepts only. Remove both from docs and tests. Add ActiveDirectoryIntegrated (Kerberos) and ActiveDirectoryServicePrincipalCertificate to the docs table as they are valid mssql-jdbc modes confirmed by javap. Suppress verbose azure-identity DefaultAzureCredential chain probe messages (EnvironmentCredential unavailable, WorkloadIdentity unavailable, ManagedIdentityCredential unavailable, etc.) in logback.xml by setting com.azure.identity to WARN and com.microsoft.aad.msal4j to ERROR. These INFO-level messages are expected on a developer machine but extremely noisy when multiple connection threads each walk the full credential chain. Reported by audunsolemdal in #1754.
dimitri
force-pushed
the
fix/mssql-azure-identity
branch
from
c31179a to
e7b3ef5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1755, reported by @audunsolemdal in #1754.
Fixes
1. Remove
ActiveDirectoryAzCliandActiveDirectoryWorkloadIdentityfrom docsThese modes do not exist in
mssql-jdbc12.6.1. Confirmed viajavapon theSqlAuthenticationenum — the valid values are:NotSpecified,SqlPassword,ActiveDirectoryPassword,ActiveDirectoryIntegrated,ActiveDirectoryManagedIdentity,ActiveDirectoryServicePrincipal,ActiveDirectoryServicePrincipalCertificate,ActiveDirectoryInteractive,ActiveDirectoryDefault.ActiveDirectoryAzCliandActiveDirectoryWorkloadIdentityexist only in the .NET (Microsoft.Data.SqlClient) and Go (go-mssqldb) drivers. Using either in the Java driver throws immediately:Replace with
ActiveDirectoryIntegrated(Kerberos) andActiveDirectoryServicePrincipalCertificatewhich are valid mssql-jdbc modes.2. Suppress verbose azure-identity chain probe logging
ActiveDirectoryDefaultwalksDefaultAzureCredential's chain on every new connection, emitting INFO-level messages for each unavailable credential (EnvironmentCredential unavailable,ManagedIdentityCredential unavailable, etc.) — very noisy on a developer machine where most credential types aren't configured, and multiplied by pgloader's connection pool thread count.Add to
logback.xml:This silences the expected chain traversal noise while preserving genuine warnings and errors.