Create new endpoint to save style editor schema per content type#36070
Create new endpoint to save style editor schema per content type#36070dario-daza wants to merge 15 commits into
Conversation
|
Claude finished @dario-daza's task in 1m 59s —— View job Rollback Safety Analysis
Pull Request Unsafe to Rollback!!!
Other categories checked — all SAFE:
The |
…or-schema-per-content-type
|
Pull Request Unsafe to Rollback!!!
|
…or-schema-per-content-type
…or-schema-per-content-type
…ed lock Moves the read-merge-save logic and DOT_STYLE_EDITOR_SCHEMA normalization out of ContentTypeResource into ContentTypeHelper#mergeAndSaveMetadata. The operation is now serialized per Content Type using a JVM-local striped lock (DotConcurrentFactory.getIdentifierStripedLock), re-reading inside the lock to prevent lost updates from concurrent PATCH requests on the same Content Type. Adds a concurrency integration test that asserts both keys survive when two threads patch simultaneously. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Pull Request Unsafe to Rollback!!!
|
Security ReviewNo high-confidence security findings on the changes in this PR. |
|
Question: is This new endpoint ( My concern is the interaction with the regular update path (
So if any client does a normal full-CT PUT without carrying
Mainly want to make sure the schema persisted here survives a subsequent normal CT save. |
❌ Codex Review failed —
|
The way we handled it in the frontend, it never happens, but it is possible that any REST API caller (Postman, a migration script, or a third-party integration) that makes a raw PUT and omits metadata from the body would silently wipe the schema. I added a validation that prevents this and preserves the metadata if a user omits it in a PUT request. If you want to wipe the metadata, you'll need to send metadata: null. |
…or-schema-per-content-type
Proposed Changes
Create the new
PATCH /v1/contenttype/id/{idOrVar}/metadataendpoint to avoid editing other Content Type information when creating and saving a Style Editor Schema for a Content Type.BE
PATCH /v1/contenttype/id/{idOrVar}/metadataendpoint to handle the metadata of the Content Types, specifically theDOT_STYLE_EDITOR_SCHEMAthat is related to the Style Editor Schema.FE
DotCrudServicewithhttp.This PR fixes: #35781
This PR fixes: #35979