Simplify SubscribeToAppDomainUnhandledException test to be CoreCLR-specific#11716
Draft
Copilot wants to merge 16 commits into
Draft
Simplify SubscribeToAppDomainUnhandledException test to be CoreCLR-specific#11716Copilot wants to merge 16 commits into
SubscribeToAppDomainUnhandledException test to be CoreCLR-specific#11716Copilot wants to merge 16 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The MAUI integration stage installs the full maui workload, which pulls mobile runtime workloads that are no longer produced for .NET 11. Remove the stage from the public and internal pipelines and drop the now-unused RunMAUITestJob variable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…able Address review feedback: the native build and MAUI-on-local-build flow still require the Mono runtime pack downloads and workload-install targets, so restore package-download.proj, DotNet.targets, Step_InstallDotNetPreview, the xaprepare property plumbing, the maui_tests stage, and the RunMAUITestJob variable. The PR now changes only the Mono mobile instrumentation test legs in stage-package-tests.yaml plus the temporary validation pins. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Surface the unsupported Mono mobile runtime build error directly in the workload to validate that no Mono mobile build paths remain in CI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Validation now happens through the temporary Mono mobile runtime build error in the workload, so the pinned SDK version and validation package feed are no longer needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Gate the MonoVM runtime parametrization in the build tests so the Mono variants are ignored on .NET 11 and later, where the Mono runtime is no longer supported for Android. CoreCLR and NativeAOT variants are unaffected. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Mono runtime is no longer supported for Android in .NET 11 and later. Remove the Mono runtime variants from the build tests: - Narrow the runtime parametrization ([Values], [TestCase], and the Enum.GetValues/TestCaseSource generators) to CoreCLR and NativeAOT. - Delete the Mono-only test methods and their now-unused TestCaseSource data generators. CoreCLR and NativeAOT coverage is unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Mono mobile runtime is no longer supported for Android in .NET 11, so building a project with UseMonoRuntime=true now errors with NETSDK1242. The device integration test suite still enumerated AndroidRuntime.MonoVM through [Values], Enum.GetValues, [Values(...)] and [TestCase(...)], causing those emulator legs to fail. Drop the MonoVM variants and keep CoreCLR and NativeAOT, matching the conversion already applied to Xamarin.Android.Build.Tests. Mono-only tests (AOT profiler, interpreter, LLVM, AppDomain.UnhandledException, and the MonoVM-only debugger break tests) are removed. Tests that merely pinned MonoVM now use the default CoreCLR runtime. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
LoggingPropsShouldCreateOverrideDirForRelease set debug.mono.log and asserted methods.txt in the .__override__ directory, behavior that only the Mono runtime produces. With the MonoVM pin dropped the test ran on CoreCLR, where methods.txt is never emitted, so it failed. Remove the test; CoreCLR has no equivalent output. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the temporary _ErrorOnMonoMobileRuntime target now that CI confirms no test legs build the Mono mobile runtime. The unsupported configuration is enforced by the SDK. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Restore SubscribeToAppDomainUnhandledException for CoreCLR/NativeAOT instead of deleting it. Remove the now-unused SettingCombinationsSource in InvalidConfigTests. Restore VersionCodeTests to preserve AndroidCreatePackagePerAbi coverage, ignored with a TODO until the test data is reworked for CoreCLR/NativeAOT supported ABIs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The test body already routes CoreCLR to a null unhandled-exception sender, so only NativeAOT needs to stay skipped. Aligns with #11673. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Simplify .NET 11 mobile runtime test as per review feedback
Simplify Jun 23, 2026
SubscribeToAppDomainUnhandledException test to be CoreCLR-specific
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the feedback on #11632. This PR addresses the review comment by simplifying the
SubscribeToAppDomainUnhandledExceptiontest.Original PR: #11632
Triggering review: #11632 (comment)
Changes
[Values(AndroidRuntime.CoreCLR, AndroidRuntime.NativeAOT)] AndroidRuntime runtimeparameter — the test is now CoreCLR-specific with no parameterizationIgnoreUnsupportedConfigurationguard — unnecessary for a single, always-supported configurationAssert.IgnoreblockPackageUtils.MakePackageName(runtime)— only needed when testing multiple runtimes to avoid package name collisionsexpectedSenderswitch expression with a hardcoded expected string (nullformats as empty inConsole.WriteLine)